[U-Boot] [PATCH 2/2] arm: goni: remove config.mk file

Minkyu Kang
2013-08-06T03:00:49Z

Dear Lukasz Majewski,

On 26/07/13 15:59, Lukasz Majewski wrote:
> On Fri, 26 Jul 2013 10:45:09 +0900 Minkyu Kang mk7.kang at samsung.com
> wrote,
>
> Hi Minkyu,
>
>> Dear Lukasz,
>>
>> On 25/07/13 20:05, Lukasz Majewski wrote:
>>> On Thu, 25 Jul 2013 10:45:35 +0900 Minkyu Kang mk7.kang at samsung.com
>>> wrote,
>>>
>>> Hi Minkyu,
>>>
>>>> Since config.mk is deprecated, remove this file,
>>>> and move CONFIG_SYS_TEXT_BASE define to config file.
>>>>
>>>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
>>>> ---
>>>> board/samsung/goni/config.mk | 34
>>>> ---------------------------------- include/configs/s5p_goni.h |
>>>> 3 +++ 2 files changed, 3 insertions(+), 34 deletions(-)
>>>> delete mode 100644 board/samsung/goni/config.mk
>>>>
>>>> diff --git a/board/samsung/goni/config.mk
>>>> b/board/samsung/goni/config.mk deleted file mode 100644
>>>> index e4581ca..0000000
>>>> --- a/board/samsung/goni/config.mk
>>>> +++ /dev/null
>>>> @@ -1,34 +0,0 @@
>>>> -#
>>>> -# Copyright (C) 2010 Samsung Electronics
>>>> -# Kyungmin Park <kyungmin.park@samsung.com>
>>>> -#
>>>> -# See file CREDITS for list of people who contributed to this
>>>> -# project.
>>>> -#
>>>> -# This program is free software; you can redistribute it and/or
>>>> -# modify it under the terms of the GNU General Public License as
>>>> -# published by the Free Software Foundation; either version 2 of
>>>> -# the License, or (at your option) any later version.
>>>> -#
>>>> -# This program is distributed in the hope that it will be useful,
>>>> -# but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>>> -# GNU General Public License for more details.
>>>> -#
>>>> -# You should have received a copy of the GNU General Public
>>>> License -# along with this program; if not, write to the Free
>>>> Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>>>> -# MA 02111-1307 USA
>>>> -#
>>>> -
>>>> -# On S5PC100 we use the 128 MiB OneDRAM bank at
>>>> -#
>>>> -# 0x30000000 to 0x35000000 (80MiB)
>>>> -# 0x38000000 to 0x40000000 (128MiB)
>>>> -#
>>>> -# On S5PC110 we use the 128 MiB OneDRAM bank at
>>>> -#
>>>> -# 0x30000000 to 0x35000000 (80MiB)
>>>> -# 0x40000000 to 0x50000000 (256MiB)
>>>> -#
>>>> -CONFIG_SYS_TEXT_BASE = 0x34800000
>>>> diff --git a/include/configs/s5p_goni.h
>>>> b/include/configs/s5p_goni.h index 56e8347..02355a6 100644
>>>> --- a/include/configs/s5p_goni.h
>>>> +++ b/include/configs/s5p_goni.h
>>>> @@ -45,6 +45,9 @@
>>>> /* DRAM Base */
>>>> #define CONFIG_SYS_SDRAM_BASE 0x30000000
>>>
>>> Would it be possible to change the DMC0 (Memory controller) base
>>> address from 0x30000000 to 0x20000000?
>>>
>>> This is what the Linux kernel expects.
>>> (at /arch/arm/mach-s5pv210/include/mach/memory.h)
>>>
>>
>> Maybe it will be possible. but not this patch.
>> This patch is for removing config.mk.
>>
>> btw, I don't have goni target any more.
>> So, if possible.. could you send the patch for it?
>
> No problem.
>
> BTW:
>
> Goni targets are in a heavy use at our group (for testing and middleware
> development - ext4, usb). Would you consider change of Maintainer for
> those targets?

OK. reasonable.

Thanks,
Minkyu Kang.