public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] arm:goni:mmc: Add sd card detection and initialization.
Date: Wed, 28 Aug 2013 09:39:47 +0200	[thread overview]
Message-ID: <521DA943.4060408@samsung.com> (raw)
In-Reply-To: <1376995992-20870-2-git-send-email-p.marczak@samsung.com>

Hello Minkyu,

> This change allow to use sd card on Goni the same like mmc 0.
> SD card is mmc dev 1, so it can be used like this: "fatls mmc 1:2".

Could you review this patch, please?

>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Minkyu Kang <mk7.kang@samsung.com>
> ---
>   board/samsung/goni/goni.c |   32 +++++++++++++++++++++++++++++++-
>   1 file changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/board/samsung/goni/goni.c b/board/samsung/goni/goni.c
> index c05801d..3b236b4 100644
> --- a/board/samsung/goni/goni.c
> +++ b/board/samsung/goni/goni.c
> @@ -69,6 +69,7 @@ int checkboard(void)
>   int board_mmc_init(bd_t *bis)
>   {
>   	int i;
> +	int ret;
>
>   	/* MASSMEMORY_EN: XMSMDATA7: GPJ2[7] output high */
>   	s5p_gpio_direction_output(&s5pc110_gpio->j2, 7, 1);
> @@ -91,7 +92,36 @@ int board_mmc_init(bd_t *bis)
>   		s5p_gpio_set_drv(&s5pc110_gpio->g0, i, GPIO_DRV_4X);
>   	}
>
> -	return s5p_mmc_init(0, 4);
> +	ret = s5p_mmc_init(0, 4);
> +	if (ret) {
> +		puts("MMC: Failed to init MMC:0.\n");
> +		return ret;
> +	}
> +
> +	/*
> +	 * SD card (T_FLASH) detect and init
> +	 * T_FLASH_DETECT: EINT28: GPH3[4] input mode
> +	 */
> +	s5p_gpio_cfg_pin(&s5pc110_gpio->h3, 4, GPIO_INPUT);
> +	s5p_gpio_set_pull(&s5pc110_gpio->h3, 4, GPIO_PULL_UP);
> +
> +	if (!s5p_gpio_get_value(&s5pc110_gpio->h3, 4)) {
> +		for (i = 0; i < 7; i++) {
> +			if (i == 2)
> +				continue;
> +			/* GPG2[0:6] special function 2 */
> +			s5p_gpio_cfg_pin(&s5pc110_gpio->g2, i, 0x2);
> +			/* GPG2[0:6] pull disable */
> +			s5p_gpio_set_pull(&s5pc110_gpio->g2, i, GPIO_PULL_NONE);
> +			/* GPG2[0:6] drv 4x */
> +			s5p_gpio_set_drv(&s5pc110_gpio->g2, i, GPIO_DRV_4X);
> +		}
> +		if (s5p_mmc_init(2, 4))
> +			puts("MMC: Failed to init SD card (MMC:2).\n");
> +	}
> +
> +	/* SD card init is optional so print information when it fails only */
> +	return ret;
>   }
>   #endif
>
>


-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com

  reply	other threads:[~2013-08-28  7:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-20 10:53 [U-Boot] [PATCH 1/3] arm:mmc:goni/exynos: Fix wrong mmc base register devices offset Przemyslaw Marczak
2013-08-20 10:53 ` [U-Boot] [PATCH 2/3] arm:goni:mmc: Add sd card detection and initialization Przemyslaw Marczak
2013-08-28  7:39   ` Przemyslaw Marczak [this message]
2013-08-28  8:41     ` Jaehoon Chung
2013-08-28 10:11       ` Przemyslaw Marczak
2013-08-28 14:36     ` [U-Boot] [PATCH v2] " Przemyslaw Marczak
2013-08-29  3:11       ` Jaehoon Chung
2013-08-30  2:16       ` Minkyu Kang
2013-09-02 14:05         ` Przemyslaw Marczak
2013-08-20 10:53 ` [U-Boot] [PATCH 3/3] ums: Extend ums to use all mmc devices Przemyslaw Marczak
2013-08-28  7:40   ` Przemyslaw Marczak
2013-08-28  8:44   ` Marek Vasut
2013-08-28 10:59     ` Przemyslaw Marczak
2013-08-28 11:03       ` Marek Vasut
2013-08-28 11:21         ` Przemyslaw Marczak
2013-08-28 11:25           ` Marek Vasut
2013-08-28  7:11 ` [U-Boot] [PATCH 1/3] arm:mmc:goni/exynos: Fix wrong mmc base register devices offset Przemyslaw Marczak
2013-08-28  8:45   ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521DA943.4060408@samsung.com \
    --to=p.marczak@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox