[U-Boot] [PATCH 3/3] ums: Extend ums to use all mmc devices.

Marek Vasut
2013-08-28T11:03:28Z

Dear Przemyslaw Marczak,

> On 08/28/2013 10:44 AM, Marek Vasut wrote:
> > You still use dev_num further in the code, why not convert the whole
> > thing to use *mmc ?
> >
> > Best regards,
> > Marek Vasut.
>
> Hello,
> I don't know exactly what do you mean.
> I suppose that putting "mmc device number" as a parameter is easy to
> maintain at command code and also intuitive to use at prompt.
> Do you prefer set mmc dev number by command "mmc dev <num>" ?
> Should we depends one command on another? If yes, then what about e.g.
> fat or ext command set?

What I mean is ... for example, you pass dev_num to board_ums_init() . See the
trats board, find_mmc_device() is called again in there. Why not just pass the
*mmc directly?

Best regards,
Marek Vasut