public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sricharan R <r.sricharan@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] am33xx: Enable D-CACHE on !CONFIG_SYS_DCACHE_OFF
Date: Fri, 30 Aug 2013 10:20:22 +0530	[thread overview]
Message-ID: <5220248E.60604@ti.com> (raw)
In-Reply-To: <1377275210-25194-1-git-send-email-trini@ti.com>

Hi Tom,

On Friday 23 August 2013 09:56 PM, Tom Rini wrote:
> Test on Beaglebone white over cpsw, usb ether and SD card (read and
> write), performance increased, crc32 of data matches.
>
> Signed-off-by: Tom Rini <trini@ti.com>
> ---
>  arch/arm/cpu/armv7/am33xx/board.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c
> index 2ea3d69..c261af5 100644
> --- a/arch/arm/cpu/armv7/am33xx/board.c
> +++ b/arch/arm/cpu/armv7/am33xx/board.c
> @@ -225,3 +225,11 @@ void s_init(void)
>  	sdram_init();
>  #endif
>  }
> +
> +#ifndef CONFIG_SYS_DCACHE_OFF
> +void enable_caches(void)
> +{
> +	/* Enable D-cache. I-cache is already enabled in start.S */
> +	dcache_enable();
> +}
> +#endif /* !CONFIG_SYS_DCACHE_OFF */
 This is fine. Do we have secure devices here ?

 If so, we should take care of setting the domains permissions for
 avoiding prefetch aborts. As it was done for OMAP using
 arm_init_domains. So that function and the above should be executed on
 am33xx as well.

 Thanks to Lokesh for reminding this.

Regards,
 Sricharan

  reply	other threads:[~2013-08-30  4:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23 16:26 [U-Boot] [PATCH] am33xx: Enable D-CACHE on !CONFIG_SYS_DCACHE_OFF Tom Rini
2013-08-30  4:50 ` Sricharan R [this message]
2013-08-30 21:07   ` Tom Rini
2013-08-30 21:13     ` Tom Rini
2013-09-02  3:52       ` Lokesh Vutla
2013-09-06 18:01         ` Tom Rini
2013-12-13 12:46 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5220248E.60604@ti.com \
    --to=r.sricharan@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox