From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sricharan R Date: Fri, 30 Aug 2013 10:20:22 +0530 Subject: [U-Boot] [PATCH] am33xx: Enable D-CACHE on !CONFIG_SYS_DCACHE_OFF In-Reply-To: <1377275210-25194-1-git-send-email-trini@ti.com> References: <1377275210-25194-1-git-send-email-trini@ti.com> Message-ID: <5220248E.60604@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On Friday 23 August 2013 09:56 PM, Tom Rini wrote: > Test on Beaglebone white over cpsw, usb ether and SD card (read and > write), performance increased, crc32 of data matches. > > Signed-off-by: Tom Rini > --- > arch/arm/cpu/armv7/am33xx/board.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c > index 2ea3d69..c261af5 100644 > --- a/arch/arm/cpu/armv7/am33xx/board.c > +++ b/arch/arm/cpu/armv7/am33xx/board.c > @@ -225,3 +225,11 @@ void s_init(void) > sdram_init(); > #endif > } > + > +#ifndef CONFIG_SYS_DCACHE_OFF > +void enable_caches(void) > +{ > + /* Enable D-cache. I-cache is already enabled in start.S */ > + dcache_enable(); > +} > +#endif /* !CONFIG_SYS_DCACHE_OFF */ This is fine. Do we have secure devices here ? If so, we should take care of setting the domains permissions for avoiding prefetch aborts. As it was done for OMAP using arm_init_domains. So that function and the above should be executed on am33xx as well. Thanks to Lokesh for reminding this. Regards, Sricharan