From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minkyu Kang Date: Fri, 30 Aug 2013 14:07:34 +0900 Subject: [U-Boot] [PATCH V2] Origen: Set FIMD as the default display path In-Reply-To: References: <1370602582-6332-1-git-send-email-tushar.behera@linaro.org> <1376560411-2798-1-git-send-email-tushar.behera@linaro.org> <52117A5F.3020104@samsung.com> <52119F9F.90308@samsung.com> Message-ID: <52202896.7050107@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 28/08/13 20:47, Tushar Behera wrote: > On 19 August 2013 11:30, Tushar Behera wrote: >> On 19 August 2013 10:01, Donghwa Lee wrote: >>> On 2013? 08? 19? 12:06, Tushar Behera wrote: >>>> On 19 August 2013 07:22, Donghwa Lee wrote: >>>>> On Fri, Aug 16, 2013 at 16:31, Ajay kumar wrote: >>>>> >>>>> On Thu, Aug 15, 2013 at 6:53 PM, Tushar Behera >>>>> wrote: >>>>>> On EXYNOS4210, there are three paths for display data to be processed, >>>>>> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller >>>>>> is used. >>>>>> >>>>>> Signed-off-by: Tushar Behera >>>>>> --- >>>>>> Changes for V2: >>>>>> * Updated review comments from Ajay Kumar, reusing the code from >>>>>> arch/arm/cpu/armv7/exynos/system.c. >>>>>> >>>>>> board/samsung/origen/origen.c | 3 +++ >>>>>> 1 file changed, 3 insertions(+) >>>>>> >>>>>> diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c >>>>>> index 15f77ca..bb16699 100644 >>>>>> --- a/board/samsung/origen/origen.c >>>>>> +++ b/board/samsung/origen/origen.c >>>>>> @@ -22,6 +22,9 @@ int board_init(void) >>>>>> gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE; >>>>>> >>>>>> gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL); >>>>>> + >>>>>> + set_system_display_ctrl(); >>>>>> + >>>>> Ok. You are trying to get the display up in the kernel, >>>>> without enabling the display in u-boot. >>>>> And, thats why you are making an explicit call here? >>>>> >>>> Yes, as of now, I don't want LCD support in u-boot, but I want to just >>>> enable the display path. >>>> >>> >>> If you don't need to LCD support in u-boot, which case do you need to enable the display path to FIMD? >>> >> >> This modification is essential for enabling LCD support in kernel. >> While working with DT kernel, we couldn't any suitable place in kernel >> where we can place this code. That is the reason why we thought of >> having this bit setup in u-boot. >> I understood your concept. but I feel, it's a workaround. you said. " I tried enabling CONFIG_LCD and related config options so that existing display path in u-boot is called. That somehow stalls the u-boot and I didn't want to pursue that much as calling this function fixes my issue. " Why don't you try to find the reason why stalls the u-boot. Thanks, Minkyu Kang.