public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] am33xx: Enable D-CACHE on !CONFIG_SYS_DCACHE_OFF
Date: Fri, 30 Aug 2013 17:07:17 -0400	[thread overview]
Message-ID: <52210985.8080003@ti.com> (raw)
In-Reply-To: <5220248E.60604@ti.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/30/2013 12:50 AM, Sricharan R wrote:
> Hi Tom,
> 
> On Friday 23 August 2013 09:56 PM, Tom Rini wrote:
>> Test on Beaglebone white over cpsw, usb ether and SD card (read and
>> write), performance increased, crc32 of data matches.
>>
>> Signed-off-by: Tom Rini <trini@ti.com>
>> ---
>>  arch/arm/cpu/armv7/am33xx/board.c |    8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c
>> index 2ea3d69..c261af5 100644
>> --- a/arch/arm/cpu/armv7/am33xx/board.c
>> +++ b/arch/arm/cpu/armv7/am33xx/board.c
>> @@ -225,3 +225,11 @@ void s_init(void)
>>  	sdram_init();
>>  #endif
>>  }
>> +
>> +#ifndef CONFIG_SYS_DCACHE_OFF
>> +void enable_caches(void)
>> +{
>> +	/* Enable D-cache. I-cache is already enabled in start.S */
>> +	dcache_enable();
>> +}
>> +#endif /* !CONFIG_SYS_DCACHE_OFF */
>  This is fine. Do we have secure devices here ?
> 
>  If so, we should take care of setting the domains permissions for
>  avoiding prefetch aborts. As it was done for OMAP using
>  arm_init_domains. So that function and the above should be executed on
>  am33xx as well.
> 
>  Thanks to Lokesh for reminding this.

Yes, but I can't easily test them.  I'll see if arm_init_domains just
works on non-HS devices (I know I had a failure pulling all the OMAP4
code over, but didn't try hard, just looked again at the "easy" path).

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSIQmFAAoJENk4IS6UOR1WkpUP/1dFyNkM9qk5xr37yBwmha/7
NbW0HYx2YyIHrEZ5W1KZJOXjaB6yQWtVAVKvcs2nrmo5GL+6e2ObY667EzrmxOlY
UPcXguJ1TvtiMIH+TZjzTUudeIBOQU8Tj5y2ryauvebJGYr8vlzbF22Unc3I/ehO
cRI49H573Yu+W0kReeM7lWel+uV2kx1Q4TjRqli5lj2vSjQijBEVhgdn3RQsjkVE
ff8+4N6exzczUYzSjUUh5N5RDWQnQ6qAbDKW3fkVIfo7JsgxAz1zjyqZk7j7cBAL
Xo28W4wtDY2HcwFs2wl3SlYly2Kvx+qY7IAbWhULaV5NbpNMn6ShUHO8W8fh4IDF
bQckJ1UTek5Y4VEP+3PmOcWi0EPIuRxCtYenhZAbweaUZE+YyBUCfunM85BH+NuJ
G68T7+4gNas1KFCMLFzUXFpxAN25erH5kh3A6CNbEJLhvhq+kv+zAHb/3nOO2N30
5OuyxKlQRNDZI7M/JYaxAB+8WAqzkOaAx25+ZnrBVRD6CmtrQ+67YePQlLhJamYB
nBZn/qM03JqsbacntEgL+b7gGqS62OM8ivyUegUJudfXSWfn9XZoL6ilISeezCj0
+/7jAdFDk0h2SYOhmp8zUFigsWzn7QsF3AIgBbikYZUJ9jBGbwUSc8+YaDuM79nI
LtEUu/4BbWlzKrpVC4wT
=tpnc
-----END PGP SIGNATURE-----

  reply	other threads:[~2013-08-30 21:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23 16:26 [U-Boot] [PATCH] am33xx: Enable D-CACHE on !CONFIG_SYS_DCACHE_OFF Tom Rini
2013-08-30  4:50 ` Sricharan R
2013-08-30 21:07   ` Tom Rini [this message]
2013-08-30 21:13     ` Tom Rini
2013-09-02  3:52       ` Lokesh Vutla
2013-09-06 18:01         ` Tom Rini
2013-12-13 12:46 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52210985.8080003@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox