From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 3/3] ARM: atmel: add RNDIS gadget support
Date: Wed, 4 Sep 2013 10:01:05 +0800 [thread overview]
Message-ID: <52269461.10400@atmel.com> (raw)
In-Reply-To: <201309040355.59386.marex@denx.de>
Hi Marek Vasut,
On 09/04/2013 09:55 AM, Marek Vasut wrote:
>> >I have considered to put this in driver, however, different Atmel SoC
>> >have different attributes for each endpoint and different number of
>> >endpoint.
>> >
>> >for example;
>> >at91sam9x5: EP("ep1", 1, 1024, 2, 1, 1)
>> >sama5d3x: EP("ep1", 1, 1024, 3, 1, 0)
>> >
>> >So, if I put this in driver, there will be many #ifdef. If newly SoC
>> >added, maybe we will need to add #ifdef again. So, I put it here.
> Can you not pull it into some header file at least? Having it in the board file
> will clearly result in duplication.
OK, I will put it into header file.
Thanks,
> Best regards,
> Marek Vasut
Best Regards,
Bo Shen
next prev parent reply other threads:[~2013-09-04 2:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 3:47 [U-Boot] [RFC PATCH 0/3] USB: atmel: add atmel usba udc driver support Bo Shen
2013-09-03 3:47 ` [U-Boot] [RFC PATCH 1/3] USB: gadget: add atmel usba udc driver Bo Shen
2013-09-03 22:30 ` Marek Vasut
2013-09-04 1:38 ` Bo Shen
2013-09-04 1:55 ` Marek Vasut
2013-09-03 3:47 ` [U-Boot] [RFC PATCH 2/3] ARM: atmel: correct UDPHS name Bo Shen
2013-09-03 3:47 ` [U-Boot] [RFC PATCH 3/3] ARM: atmel: add RNDIS gadget support Bo Shen
2013-09-03 22:31 ` Marek Vasut
2013-09-04 1:46 ` Bo Shen
2013-09-04 1:55 ` Marek Vasut
2013-09-04 2:01 ` Bo Shen [this message]
2013-09-04 7:32 ` Andreas Bießmann
2013-09-04 7:42 ` Bo Shen
2013-09-04 7:56 ` Andreas Bießmann
2013-09-04 12:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52269461.10400@atmel.com \
--to=voice.shen@atmel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox