From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Date: Wed, 4 Sep 2013 10:01:05 +0800 Subject: [U-Boot] [RFC PATCH 3/3] ARM: atmel: add RNDIS gadget support In-Reply-To: <201309040355.59386.marex@denx.de> References: <1378180030-26101-1-git-send-email-voice.shen@atmel.com> <201309040031.58932.marex@denx.de> <52269110.1030905@atmel.com> <201309040355.59386.marex@denx.de> Message-ID: <52269461.10400@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek Vasut, On 09/04/2013 09:55 AM, Marek Vasut wrote: >> >I have considered to put this in driver, however, different Atmel SoC >> >have different attributes for each endpoint and different number of >> >endpoint. >> > >> >for example; >> >at91sam9x5: EP("ep1", 1, 1024, 2, 1, 1) >> >sama5d3x: EP("ep1", 1, 1024, 3, 1, 0) >> > >> >So, if I put this in driver, there will be many #ifdef. If newly SoC >> >added, maybe we will need to add #ifdef again. So, I put it here. > Can you not pull it into some header file at least? Having it in the board file > will clearly result in duplication. OK, I will put it into header file. Thanks, > Best regards, > Marek Vasut Best Regards, Bo Shen