From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= Date: Wed, 04 Sep 2013 17:15:14 +0200 Subject: [U-Boot] [PATCH] MTD: atmel_nand: support for software BCH ECC In-Reply-To: <52272BB7.8050900@gmail.com> References: <1377701666-9632-1-git-send-email-voice.shen@gmail.com> <52270A1A.2080205@gmail.com> <5227238B.8020205@gmail.com> <522727DC.5020209@gmail.com> <52272BB7.8050900@gmail.com> Message-ID: <52274E82.6030300@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Bo, On 09/04/2013 02:46 PM, Bo Shen wrote: > On 9/4/2013 8:30 PM, Andreas Bie?mann wrote: >>> >Yes, we need libbch. >>> > >>> >If we really want to enable software BCH support. It also need add >>> >following two options in board configuration file. >>> >---8>--- >>> >#define CONFIG_NAND_ECC_BCH >>> >#define CONFIG_BCH >>> >---<8--- >>> > >>> >So, this patch give us option to enable software BCH. >> got it. So the NAND_ECC_BCH is the adoption for the SW BCH correction in >> mtd layer. I understand that this would be helpful for at91 SoC without >> PMECC HW. But there is no user currently, so I hesitate to apply this. > > Frankly, there is no EK boards from Atmel use software BCH now, however, > a lot of customers use NAND with 224 bytes OOB, can not use software > ECC, they need use software BCH. I understand this. But it will be a piece of dead code until a user of it would be submitted. > So, I think it is better to apply this patch. If it will break the rule > of u-boot, then I think we can wait real user in u-boot need this and > then apply this patch. I'd like to hear Scott's comment on that. Best regards Andreas Bie?mann