From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: tegra: Add the Tamonten™ NG Evaluation Carrier board
Date: Wed, 04 Sep 2013 12:05:00 -0600 [thread overview]
Message-ID: <5227764C.3000206@wwwdotorg.org> (raw)
In-Reply-To: <1378299618-29799-2-git-send-email-alban.bedel@avionic-design.de>
On 09/04/2013 07:00 AM, Alban Bedel wrote:
> Add support for the new Tamonten? NG platform from Avionic Design.
> Currently only I2C, MMC, USB and ethernet have been tested.
(Also CC'ing the Tegra maintainer here)
> diff --git a/board/avionic-design/common/tamonten-ng.c
> b/board/avionic-design/common/tamonten-ng.c
> +void pmu_write(uchar reg, uchar data) +{ + int i; +
> i2c_set_bus_num(0); /* PMU is on bus 0 */ + for (i = 0; i <
> MAX_I2C_RETRY; ++i) { + if (i2c_write(PMU_I2C_ADDRESS, reg, 1,
> &data, 1)) + udelay(100); + else + break; + } +}
Is there really a need to retry the I2C transactions? If so, why do
they fail? I assume this was just copy/pasted from some other board
file, and there's no need for any retries?
It'd be nice if there was a proper PMU subsystem, so we could have a
specific driver for each PMU chip, rather than having
open-coded/custom writes to the PMU registers in each board file, but
I guess that's not an issue with this patch specfically.
> diff --git a/include/configs/tec-ng.h b/include/configs/tec-ng.h
> +/* support the new (FDT-based) image format */ +#define
> CONFIG_FIT
Hmmm. Do the standard Tegra boot scripts in tegra-common-post.h deal
well with FIT? I've tried to avoid FIT usage as much as possible.
next prev parent reply other threads:[~2013-09-04 18:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 13:00 [U-Boot] [PATCH 1/2] ARM: tegra: support SKU b1 of Tegra30 Alban Bedel
2013-09-04 13:00 ` [U-Boot] [PATCH 2/2] ARM: tegra: Add the Tamonten™ NG Evaluation Carrier board Alban Bedel
2013-09-04 18:05 ` Stephen Warren [this message]
2013-09-05 12:46 ` Alban Bedel
2013-09-05 19:15 ` Stephen Warren
2013-09-04 17:59 ` [U-Boot] [PATCH 1/2] ARM: tegra: support SKU b1 of Tegra30 Stephen Warren
2013-09-20 12:45 ` Thierry Reding
2013-09-20 16:03 ` Stephen Warren
2013-09-20 17:57 ` Tom Warren
2013-09-23 8:51 ` Alban Bedel
2013-09-24 0:23 ` Tom Warren
2013-10-17 9:29 ` Alban Bedel
2013-10-17 10:50 ` Thierry Reding
2013-10-17 14:59 ` Stephen Warren
2013-10-17 15:26 ` Thierry Reding
2013-10-17 15:45 ` Tom Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5227764C.3000206@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox