From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Wed, 04 Sep 2013 12:05:00 -0600
Subject: [U-Boot]
 =?utf-8?q?=5BPATCH_2/2=5D_ARM=3A_tegra=3A_Add_the_Tamont?=
 =?utf-8?q?en=E2=84=A2_NG_Evaluation_Carrier_board?=
In-Reply-To: <1378299618-29799-2-git-send-email-alban.bedel@avionic-design.de>
References: <1378299618-29799-1-git-send-email-alban.bedel@avionic-design.de>
	<1378299618-29799-2-git-send-email-alban.bedel@avionic-design.de>
Message-ID: <5227764C.3000206@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09/04/2013 07:00 AM, Alban Bedel wrote:
> Add support for the new Tamonten? NG platform from Avionic Design. 
> Currently only I2C, MMC, USB and ethernet have been tested.

(Also CC'ing the Tegra maintainer here)

> diff --git a/board/avionic-design/common/tamonten-ng.c
> b/board/avionic-design/common/tamonten-ng.c

> +void pmu_write(uchar reg, uchar data) +{ +	int i; +
> i2c_set_bus_num(0);	/* PMU is on bus 0 */ +	for (i = 0; i <
> MAX_I2C_RETRY; ++i) { +		if (i2c_write(PMU_I2C_ADDRESS, reg, 1,
> &data, 1)) +			udelay(100); +		else +			break; +	} +}

Is there really a need to retry the I2C transactions? If so, why do
they fail? I assume this was just copy/pasted from some other board
file, and there's no need for any retries?

It'd be nice if there was a proper PMU subsystem, so we could have a
specific driver for each PMU chip, rather than having
open-coded/custom writes to the PMU registers in each board file, but
I guess that's not an issue with this patch specfically.

> diff --git a/include/configs/tec-ng.h b/include/configs/tec-ng.h

> +/* support the new (FDT-based) image format */ +#define
> CONFIG_FIT

Hmmm. Do the standard Tegra boot scripts in tegra-common-post.h deal
well with FIT? I've tried to avoid FIT usage as much as possible.