From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: lds: Remove libgcc eabi exception handling tables
Date: Fri, 06 Sep 2013 10:12:22 +0200 [thread overview]
Message-ID: <52298E66.3000803@monstr.eu> (raw)
In-Reply-To: <20130905211659.2a1213d3@lilith>
On 09/05/2013 09:16 PM, Albert ARIBAUD wrote:
> Hi Michal,
>
> On Thu, 25 Jul 2013 16:16:46 +0200, Michal Simek
> <michal.simek@xilinx.com> wrote:
>
>> Remove ARM eabi exception handling tables (for frame unwinding).
>> AFAICT, u-boot stubs away the frame unwiding routines, so the tables will
>> more or less just consume space. It should be OK to remove them.
>>
>> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>> This patch was sent to ML as RFC (May 9)
>>
>> Here is the origin response in connection to this patch.
>>
>> Ok, so Michal and I just did some fiddling with zynq builds and
>> *exidx* sections.
>>
>> By default the *exidx* sections are between rodata and data, so
>> removing them causes many apparent changes at the binary level.
>> However, builds of zynq based on ARM master with the patch above vs
>> master with a patch mapping *exidx* sections after BSS gives identical
>> binaries. Thus the RFC has no functional effect.
>>
>> Also, ARM EHABI states that [exception] Tables are not required for ABI
>> compliance at the C/Assembler level but are required for C++.
>>
>> http://infocenter.arm.com/help/topic/com.arm.doc.ihi0038a/IHI0038A_ehabi.pdf
>>
>> So as long as we don't put any C++ code in U-Boot (a prospect that I
>> don't see happening any time soon), this RFC is safe and either is a
>> no-op or removes useless bytes from the binary.
>>
>> ---
>> arch/arm/cpu/u-boot.lds | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/cpu/u-boot.lds b/arch/arm/cpu/u-boot.lds
>> index 3037885..8894c8a 100644
>> --- a/arch/arm/cpu/u-boot.lds
>> +++ b/arch/arm/cpu/u-boot.lds
>> @@ -113,4 +113,6 @@ SECTIONS
>> /DISCARD/ : { *(.plt*) }
>> /DISCARD/ : { *(.interp*) }
>> /DISCARD/ : { *(.gnu*) }
>> + /DISCARD/ : { *(.ARM.exidx*) }
>> + /DISCARD/ : { *(.gnu.linkonce.armexidx.*) }
>> }
>> --
>> 1.8.2.3
>>
>
> Applied to u-boot-arm/master, thanks!
>
Ok. Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130906/f590099a/attachment.pgp>
prev parent reply other threads:[~2013-09-06 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 14:16 [U-Boot] [PATCH] arm: lds: Remove libgcc eabi exception handling tables Michal Simek
2013-09-05 13:03 ` Albert ARIBAUD
2013-09-05 15:30 ` Michal Simek
2013-09-05 16:05 ` Albert ARIBAUD
2013-09-06 8:11 ` Michal Simek
2013-09-05 19:16 ` Albert ARIBAUD
2013-09-06 8:12 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52298E66.3000803@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox