From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mateusz Zalega Date: Fri, 06 Sep 2013 13:36:08 +0200 Subject: [U-Boot] [PATCH v3] usb: new board-specific USB init interface In-Reply-To: <201309061324.38445.marex@denx.de> References: <1375786242-11734-1-git-send-email-m.zalega@samsung.com> <201309051951.57034.marex@denx.de> <5229BADE.3040202@samsung.com> <201309061324.38445.marex@denx.de> Message-ID: <5229BE28.7050309@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/06/13 13:24, Marek Vasut wrote: >>>>> Moreover, the 'int index' should likely be unsigned int and the special >>>>> value to init all controllers at once should probably then be >>>>> 0xffffffff >>>> >>>> Despite our greatest ambitions, I don't think we're likely to use more >>>> than 2^31-1 USB controllers at a time. Besides, negative values look >>>> better both in code and debugger session. >>> >>> Thinking of it further, instead of using negative value here, like I >>> mentioned above, why not make the "board_usb_init_type" into a field of >>> flags , then add flag to init all controllers at once ? >> >> That's unnecessary. It wouldn't lead to any practical advantage over >> existing interface. > > The advantage would be you won't be mixing two things (value AND value with > special meaning) into the "index" parameter. Alright, provide a use-case. The only 'special' value we have now doesn't interfere with controller index. Why write code or interfaces that won't ever be used? Best regards, -- Mateusz Zalega Samsung R&D Institute Poland