From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc:sdhci: Fix card ready status timeout.
Date: Fri, 06 Sep 2013 17:23:33 +0200 [thread overview]
Message-ID: <5229F375.9060805@samsung.com> (raw)
In-Reply-To: <D5EDFA40-ECCE-4B74-8F29-041E41383553@antoniou-consulting.com>
Hello Pantelis,
> On 09/06/2013 03:24 PM, Pantelis Antoniou wrote:
> Hi there,
>
> Can we have a config option for these two values instead of magic numbers?
>
> With the defaults being set at 10 & 200 ms.
>
> Regards
>
> -- Pantelis
I'm not sure that this option is needed. Some cards I/O errors can be
avoided by increasing timeout and has no negative influence on other
cards read/write operations performance.
Moreover there are a lot of timeout values defined in sdhci and mmc
drivers, so why should I put at config just only one? Maybe the simplest
solution is to leave at this code only 200 ms value.
What do you think?
Regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
next prev parent reply other threads:[~2013-09-06 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 12:50 [U-Boot] [PATCH] mmc:sdhci: Fix card ready status timeout Przemyslaw Marczak
2013-09-06 13:24 ` Pantelis Antoniou
2013-09-06 15:23 ` Przemyslaw Marczak [this message]
2013-09-06 15:27 ` Pantelis Antoniou
2013-09-09 12:58 ` Przemyslaw Marczak
2013-09-13 12:59 ` Przemyslaw Marczak
2013-09-16 16:34 ` Pantelis Antoniou
-- strict thread matches above, loose matches on Subject: below --
2013-08-28 16:49 Przemyslaw Marczak
2013-08-29 3:16 ` Jaehoon Chung
2013-09-02 14:16 ` Przemyslaw Marczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5229F375.9060805@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox