From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Fri, 06 Sep 2013 17:23:33 +0200 Subject: [U-Boot] [PATCH] mmc:sdhci: Fix card ready status timeout. In-Reply-To: References: <1378212631-25526-1-git-send-email-p.marczak@samsung.com> Message-ID: <5229F375.9060805@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Pantelis, > On 09/06/2013 03:24 PM, Pantelis Antoniou wrote: > Hi there, > > Can we have a config option for these two values instead of magic numbers? > > With the defaults being set at 10 & 200 ms. > > Regards > > -- Pantelis I'm not sure that this option is needed. Some cards I/O errors can be avoided by increasing timeout and has no negative influence on other cards read/write operations performance. Moreover there are a lot of timeout values defined in sdhci and mmc drivers, so why should I put at config just only one? Maybe the simplest solution is to leave at this code only 200 ms value. What do you think? Regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com