From: "Jiří Prchal" <jiri.prchal@aksignal.cz>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Subject: [PATCH v.2] at91: add support for CDU9G25 board
Date: Tue, 10 Sep 2013 09:58:55 +0200 [thread overview]
Message-ID: <522ED13F.90303@aksignal.cz> (raw)
In-Reply-To: <20130909153431.62F1E380E12@gemini.denx.de>
Hi Wolfgang,
Dne 9.9.2013 17:34, Wolfgang Denk napsal(a):
> Dear Jiri Prchal,
>
> In message <1378736524-30870-1-git-send-email-jiri.prchal@aksignal.cz> you wrote:
>> This patch adds support for our companies board CDU9G25 with Atmel AT91SAM9G25, 128MB DDR2, 256MB NAND.
>
> Please keep the line length of the commit message < 70 characters.
>
>> v.2
>> Fixed static IP and MAC addr cofiguration by random MAC and DHCP.
>> Added entry to MAINTAINERS.
>> Fixed line lenght, trailing spaces and other cosmetics.
>
> This comment does not belong into the commit message - please move it
> to the comment section, i. e. below the "---" line.
I'm not sure if I even should number versions of this patch?
>
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -939,6 +939,9 @@ Bo Shen <voice.shen@atmel.com>
>> at91sam9x5ek ARM926EJS (AT91SAM9G15,G25,G35,X25,X35 SoC)
>> sama5d3xek ARMV7 (SAMA5D31, D33, D34, D35 SoC)
>>
>> +Jiri Prchal <jiri.prchal@aksignal.cz>
>> + cdu9g25 ARM926EJS (AT91SAM9G25 SoC)
>> +
>> Rajeshwari Shinde <rajeshwari.s@samsung.com>
>
> Please keep the list sorted.
>
>
>> +#define CONFIG_BOOTARGS "console=ttyS0,115200 ubi.mtd=root"\
>> + "root=ubi0:root rootfstype=ubifs rw"\
>> + "g_ether.dev_addr=02:04:25:aa:55:5e"\
>> + "g_ether.host_addr=02:04:25:aa:55:5f"
This is here for linux connection with PC via USB ethernet gadget. I'd like static IP for this connection but if there
is random MAC addr I must set up IP again and again. Is another solution for this?
>> +#define CONFIG_SERVERIP 10.0.1.1
Please help me with this:
I'd like to have board prepared for download images from TFTP server on address 10.0.1.1.
Is there other way how to do it? Even with MAC addr, I solved it with random MAC, is that OK? I keep in mind that would
be nice read unique serial number from F-RAM (is on boart too) on SPI and use it as MAC addr. Will be this way better?
>
> We do not allow static network configuration in board config files!
> Please get rid of these MAC and IP addresses here.
>
> Best regards,
>
> Wolfgang Denk
>
With many thanks,
Jiri
next prev parent reply other threads:[~2013-09-10 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 14:22 [U-Boot] [PATCH] Subject: [PATCH v.2] at91: add support for CDU9G25 board Jiri Prchal
2013-09-09 15:34 ` Wolfgang Denk
2013-09-10 7:58 ` Jiří Prchal [this message]
2013-09-10 9:26 ` Andreas Bießmann
2013-09-10 22:52 ` Wolfgang Denk
2013-09-11 7:39 ` Jiří Prchal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522ED13F.90303@aksignal.cz \
--to=jiri.prchal@aksignal.cz \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox