public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/p2041: fix I2C controller's offset
Date: Wed, 11 Sep 2013 06:44:49 +0200	[thread overview]
Message-ID: <522FF541.6070900@denx.de> (raw)
In-Reply-To: <522F8BB4.5000907@freescale.com>

Hello York,

Am 10.09.2013 23:14, schrieb York Sun:
> On 09/10/2013 02:13 PM, Chris Packham wrote:
>> Hi Xie,
>>
>> On Tue, Sep 10, 2013 at 8:15 PM, Shaohui Xie<Shaohui.Xie@freescale.com>  wrote:
>>> Without this patch, SPD access will fail which leads to DDR init fail.
>>>
>>> Signed-off-by: Shaohui Xie<Shaohui.Xie@freescale.com>
>>> ---
>>>   include/configs/P2041RDB.h |    4 ++--
>>>   1 files changed, 2 insertions(+), 2 deletions(-)

Thanks for this fix!

>>> diff --git a/include/configs/P2041RDB.h b/include/configs/P2041RDB.h
>>> index 905bacf..862614b 100644
>>> --- a/include/configs/P2041RDB.h
>>> +++ b/include/configs/P2041RDB.h
>>> @@ -354,10 +354,10 @@ unsigned long get_board_sys_clk(unsigned long dummy);
>>>   #define CONFIG_SYS_I2C_FSL
>>>   #define CONFIG_SYS_FSL_I2C_SPEED       400000
>>>   #define CONFIG_SYS_FSL_I2C_SLAVE       0x7F
>>> -#define CONFIG_SYS_FSL_I2C_OFFSET      0x3000
>>> +#define CONFIG_SYS_FSL_I2C_OFFSET      0x118000
>>>   #define CONFIG_SYS_FSL_I2C2_SPEED      400000
>>>   #define CONFIG_SYS_FSL_I2C2_SLAVE      0x7F
>>> -#define CONFIG_SYS_FSL_I2C2_OFFSET     0x3100
>>> +#define CONFIG_SYS_FSL_I2C2_OFFSET     0x118100
>>>
>>>   /*
>>>    * RapidIO
>>> --
>>> 1.7.0.4
>>>
>>
>> Yes that appears to fix the problem. Thanks for the quick turn around.
>>
>> Tested-by: Chris Packham<judge.packham@gmail.com>

Thanks for testing.

> Thanks for the feedback. I will take it in u-boot-mpc85xx.

Ah, Ok, I am fine with this, so:

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      reply	other threads:[~2013-09-11  4:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10  8:15 [U-Boot] [PATCH] powerpc/p2041: fix I2C controller's offset Shaohui Xie
2013-09-10 21:13 ` Chris Packham
2013-09-10 21:14   ` York Sun
2013-09-11  4:44     ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522FF541.6070900@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox