From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minkyu Kang <mk7.kang@samsung.com>
Date: Wed, 11 Sep 2013 16:53:01 +0900
Subject: [U-Boot] [PATCH V4 1/3] power:battery: add battery support for
	Trats2 board
In-Reply-To: <007501cea546$3c95ff40$b5c1fdc0$%wilczek@samsung.com>
References: <1369383791-21795-1-git-send-email-p.wilczek@samsung.com>
	<1377766145-6678-1-git-send-email-p.wilczek@samsung.com>
	<1377766145-6678-2-git-send-email-p.wilczek@samsung.com>
	<522021F5.7060105@samsung.com>
	<007501cea546$3c95ff40$b5c1fdc0$%wilczek@samsung.com>
Message-ID: <5230215D.60009@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Piotr Wilczek,

On 30/08/13 15:00, Piotr Wilczek wrote:
> Dear Minkyu Kang,
> 
>> -----Original Message-----
>> From: Minkyu Kang [mailto:mk7.kang at samsung.com]
>> Sent: Friday, August 30, 2013 6:39 AM
>> To: Piotr Wilczek
>> Cc: u-boot at lists.denx.de; Kyungmin Park; Lukasz Majewski
>> Subject: Re: [PATCH V4 1/3] power:battery: add battery support for
>> Trats2 board
>>
>> Dear Piotr Wilczek,
>>
>> On 29/08/13 17:49, Piotr Wilczek wrote:
>>> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>> ---
>>>  drivers/power/battery/Makefile     |    1 +
>>>  drivers/power/battery/bat_trats2.c |   65
>> ++++++++++++++++++++++++++++++++++++
>>>  2 files changed, 66 insertions(+)
>>>  create mode 100644 drivers/power/battery/bat_trats2.c
>>>
>>
>> bat_trats2.c is almost same with bat_trat.c I think, it can be reuse
>> bat_trat.c Do you have special reason to add new file?
> 
> If several boards would use that file, any change to it will affect all
> these boards. Also why it should be named 'bat_trats' then?

OK. I understood what you said.

But, I don't understand why this file (or directory - battery) is needed.
It is not a driver,
it just settings for specific board.
If so, why don't you move to board file instead?
Do we need to make new files for every boards?

Lukasz,
how you think?

> 
> Other reason is that I don't want to block command line while charging
> battery as in 'bat_trats'.
> 
> Anyway it's not that important. I will modify it the way you prefer.
> 
> Best regards,
> Piotr Wilczek
> 
>>
>> Thanks,
>> Minkyu Kang.
> 
> 
> 

Thanks,
Minkyu Kang.