From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bo Shen <voice.shen@atmel.com>
Date: Wed, 11 Sep 2013 18:15:42 +0800
Subject: [U-Boot] [PATCH v2 3/3] ARM: atmel: add RNDIS gadget support
In-Reply-To: <201309101629.18010.marex@denx.de>
References: <1378807422-1583-1-git-send-email-voice.shen@atmel.com>
	<1378807422-1583-4-git-send-email-voice.shen@atmel.com>
	<201309101629.18010.marex@denx.de>
Message-ID: <523042CE.6080001@atmel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek Vasut,

On 9/10/2013 22:29, Marek Vasut wrote:
> Dear Bo Shen,
>
>> Add RNDIS gadget support to test atmel usba udc driver
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>
>> ---
>> Changes in v2:
>>    - Add a common header to hold atmel usba udc information for different
>>      SoCs
>> ---
>>   arch/arm/cpu/armv7/at91/sama5d3_devices.c       |   12 +++++
>>   arch/arm/include/asm/arch-at91/at91_common.h    |    1 +
>>   arch/arm/include/asm/arch-at91/atmel_usba_udc.h |   64
>> +++++++++++++++++++++++ board/atmel/sama5d3xek/sama5d3xek.c             |
>>   13 +++++
>>   include/configs/sama5d3xek.h                    |    8 +++
>>   5 files changed, 98 insertions(+)
>>   create mode 100644 arch/arm/include/asm/arch-at91/atmel_usba_udc.h
>>
>> diff --git a/arch/arm/cpu/armv7/at91/sama5d3_devices.c
>> b/arch/arm/cpu/armv7/at91/sama5d3_devices.c index e55e1c6..51f0a6d 100644
>> --- a/arch/arm/cpu/armv7/at91/sama5d3_devices.c
>> +++ b/arch/arm/cpu/armv7/at91/sama5d3_devices.c
>> @@ -202,3 +202,15 @@ void at91_lcd_hw_init(void)
>>   	at91_periph_clk_enable(ATMEL_ID_LCDC);
>>   }
>>   #endif
>> +
>> +#ifdef CONFIG_USB_GADGET_ATMEL_USBA
>> +void at91_udp_hw_init(void)
>> +{
>> +	struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
>> +
>> +	/* Enable UPLL clock */
>> +	writel(AT91_PMC_UPLLEN | AT91_PMC_BIASEN, &pmc->uckr);
>> +	/* Enable UDPHS clock */
>> +	at91_periph_clk_enable(ATMEL_ID_UDPHS);
>> +}
>> +#endif
>> diff --git a/arch/arm/include/asm/arch-at91/at91_common.h
>> b/arch/arm/include/asm/arch-at91/at91_common.h index 9f54fdd..abcb97d
>> 100644
>> --- a/arch/arm/include/asm/arch-at91/at91_common.h
>> +++ b/arch/arm/include/asm/arch-at91/at91_common.h
>> @@ -19,6 +19,7 @@ void at91_serial2_hw_init(void);
>>   void at91_seriald_hw_init(void);
>>   void at91_spi0_hw_init(unsigned long cs_mask);
>>   void at91_spi1_hw_init(unsigned long cs_mask);
>> +void at91_udp_hw_init(void);
>>   void at91_uhp_hw_init(void);
>>   void at91_lcd_hw_init(void);
>>
>> diff --git a/arch/arm/include/asm/arch-at91/atmel_usba_udc.h
>> b/arch/arm/include/asm/arch-at91/atmel_usba_udc.h new file mode 100644
>> index 0000000..6f540d2
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arch-at91/atmel_usba_udc.h
>
> This new file should be added alongside the USB driver, not board stuff.

OK, I will move this file into USB driver patch.

> [...]
>
> Best regards,
> Marek Vasut
>

Best Regards,
Bo Shen