[U-Boot] [PATCH] net: fec: Avoid MX28 bus sync issue

Marek Vasut
2013-09-12T14:05:04Z

Dear Robert Hodaszi,

> Hi,
>
> Sorry, hopefully that will be a plain-text.
>
> There are a lot of bug announcement, just make a search:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33721

This was apparently fixed three years ago.

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16660

And this one six years ago ...

> Also, I printed out the buffer addresses, and that temporary RX buffer
> was not aligned. So the transmit function rounded it down to the
> alignment boundary, and so caused invalid data transmission. (By the
> way. Shouldn't the transmit function check whether the alignment is
> proper, and throw an error message, instead of round it down? That would
> make more sense.)

Looking at the code one more time, it'd make most sense to simply allocate the
buffer NOT on stack, but with some memalign-kind-of call to avoid this abuse of
stack. You see, the max packet size is around 2k, which is quite a lot. How does
this proposal sound to you ?

Best regards,
Marek Vasut