From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 18 Sep 2013 09:13:45 +0200 Subject: [U-Boot] [PATCH] i2c:zynq: I2C multi-bus support on Zynq In-Reply-To: References: Message-ID: <523952A9.3040705@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Michael, a "How to send patches", Jagan Teki responded to you, so I only comment your patch ... Am 17.09.2013 19:29, schrieb Michael Burr: > Zynq PS has two I2C bus masters (called 'I2C0' and 'I2C1'): >> Implement 'i2c_set_bus_num' routine to select from these. > Support I2C devices which do not use internal addresses: >> Handle case of 'alen == 0' in 'i2c_read', 'i2c_write'. > This supports PCA9548 bus multiplexer on Xilinx ZC702 board. > Tested cases of 'alen == 0' and 'alen == 1' on this board. > Further minor corrections: >> Write 'address' register before 'data' register. >> Write 'transfer_size' register before 'address' register. > > Signed-off-by: Michael Burr > Cc: Albert Aribaud > Cc: Heiko Schocher > Cc: Michal Simek > --- > drivers/i2c/zynq_i2c.c | 87 ++++++++++++++++++++++++++++++------------------ > 1 file changed, 55 insertions(+), 32 deletions(-) Thanks for your work! But please use the new i2c multibus/multiadapter framework for adding multibus support for this driver. Currently 4 i2c drivers are ported to this new framework, see: http://git.denx.de/?p=u-boot.git;a=commitdiff;h=880540decfb855e96bc14ac84ac7784669e4b382 http://git.denx.de/?p=u-boot.git;a=commitdiff;h=1f2ba722ac06393d6abe6d4734824d3b98ea9108 http://git.denx.de/?p=u-boot.git;a=commitdiff;h=00f792e0df9ae942427e44595a0f4379582accee http://git.denx.de/?p=u-boot.git;a=commitdiff;h=ea818dbbcd59300b56014ac2d67798a54994eb9b You can use them as a base for your work bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany