From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition
Date: Thu, 19 Sep 2013 18:13:21 -0400 [thread overview]
Message-ID: <523B7701.3080606@ti.com> (raw)
In-Reply-To: <CAL_Jsq+_=YmPreWF2acjy07-_vjLaw24J=HqdJ54jF2JSzoz+Q@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/19/2013 05:02 PM, Rob Herring wrote:
> On Thu, Sep 19, 2013 at 2:06 PM, Tom Rini <trini@ti.com> wrote:
>> On Mon, Sep 09, 2013 at 05:41:46PM +0200, Wolfgang Denk wrote:
>>> Dear Rob,
>>>
>>> In message <522DE2FF.2080001@gmail.com> you wrote:
>>>>
>>>> What do I do with current boards that are wrong? I should make all these
>>>
>>> Good question...
>>>
>>>> boards have build errors or fix them to use 1000 which may break them at
>>>> runtime depending on their possible misuse of CONFIG_SYS_HZ?
>>>>
>>>> include/configs/KAREF.h:#define CONFIG_SYS_HZ 100
>>>> /* decr freq: 1 ms ticks */
>>>> include/configs/M5271EVB.h:#define CONFIG_SYS_HZ
>>>> 1000000
>>>> include/configs/METROBOX.h:#define CONFIG_SYS_HZ
>>>> 100 /* decr freq: 1 ms ticks */
>>>> include/configs/MVBLUE.h:#define CONFIG_SYS_HZ 10000
>>>> include/configs/idmr.h:#define CONFIG_SYS_HZ
>>>> (50000000 / 64)
>>>> include/configs/mini2440.h:#define CONFIG_SYS_HZ
>>>> 1562500
>>>> include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400
>>>> include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ
>>>> ((V_SCLK) / (2 << CONFIG_SYS_PTV))
>>>> include/configs/omap730p2.h:#define CONFIG_SYS_HZ
>>>> ((CONFIG_SYS_CLK_FREQ)/(2 << CONFIG_SYS_PTV))
>>>> include/configs/rsk7203.h:#define CONFIG_SYS_HZ
>>>> (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER)
>>>> include/configs/rsk7264.h:#define CONFIG_SYS_HZ
>>>> (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER)
>>>> include/configs/rsk7269.h:#define CONFIG_SYS_HZ
>>>> (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER)
>>>> include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400
>>>> /* incrementer freq: 3.6864 MHz */
>>>> include/configs/versatile.h:#define CONFIG_SYS_HZ
>>>> (1000000 / 256)
>>>
>>> Hm... which of these boards are actually still being maintained?
>>>
>>> KAREF and METROBOX are PPC systems, and the comment suggests that the
>>> value is actually just a typo. Here it should be harmless to change
>>> this to use 1000 Hz instead. Ditto probably for MVBLUE. The rest
>>> might actually be dead?
>>>
>>> Guess we should have their builds break and make the board maintainers
>>> fix them. If they don't (because the boards are unmaintained), we
>>> will drop the board code from the repo.
>>
>> Actually breaking them will cause hell on the folks building everything.
>> Lets correct the ones we can correct easily and poke maintainers for the
>> rest so we know what we can/should move to orphaned or just drop.
>
> How about just a warning instead? Here's an updated list which missed some:
>
> include/configs/M5271EVB.h:#define CONFIG_SYS_HZ 1000000
> include/configs/balloon3.h:#define CONFIG_SYS_HZ
> 3250000 /* Timer @ 3250000 Hz */
> include/configs/idmr.h:#define CONFIG_SYS_HZ (50000000 / 64)
> include/configs/mini2440.h:#define CONFIG_SYS_HZ 1562500
> include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400
> include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ
> ((V_SCLK) / (2 << CONFIG_SYS_PTV))
> include/configs/omap730p2.h:#define CONFIG_SYS_HZ
> ((CONFIG_SYS_CLK_FREQ)/(2 << CONFIG_SYS_PTV))
> include/configs/palmld.h:#define CONFIG_SYS_HZ
> 3250000 /* Timer @ 3250000 Hz */
> include/configs/palmtc.h:#define CONFIG_SYS_HZ
> 3686400 /* Timer @ 3686400 Hz */
> include/configs/rsk7203.h:#define CONFIG_SYS_HZ
> (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER)
> include/configs/rsk7264.h:#define CONFIG_SYS_HZ
> (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER)
> include/configs/rsk7269.h:#define CONFIG_SYS_HZ
> (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER)
> include/configs/scb9328.h:#define CONFIG_SYS_HZ
> 3686400 /* incrementer freq: 3.6864 MHz */
> include/configs/versatile.h:#define CONFIG_SYS_HZ
> (1000000 / 256)
> include/configs/zipitz2.h:#define CONFIG_SYS_HZ
> 3250000 /* Timer @ 3250000 Hz */
I could live with that I think.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSO3cBAAoJENk4IS6UOR1W0I4P/0l+rxS4C6tiFmCIQo9Wtf2i
owKufT+cvGsQCtzbH84g3gUR/0bLE+FTAslYLyZ8DptFqlpOnOtc+pHqlOVgWZAp
R1mZyVz1jU+8bRkieDFb6tv6PFGcXAkcC37epKlVk6b9A0vJnm6xEXQ1Hwb7XGhG
j5DZ8KeUXWYyGcn5SYY5wRMztWcfQMMZ8MQVbioD8LE2vh7E2QnWBio168yfUS8l
rbvxoykj6fxikYCWcdlr7ov7adzCa+nmwc4u0qxXzXro5Nm0uZ98FnJSj0HmuaS0
ISG0VMO+E6BnBFOBhwYbAgKgSFvTdxM8yo5lU66UuzVwVYvqqANbHhAR0I+8e4v4
k8jlouvUcFuQycWAotZopfqPnHMpDx51UYEjIcgw+MvCc9KqIH07epDOKuq4TLgn
tGrM2N6HyX+ofKjKB1r6zRrqECzbGu8E5fAZNf/JrNgUTbfFRhmMvLFJ7F99ZUb+
chjveTUsY2yCmadgwxrQjOTLBn9MCabFqkm/mGweN+EjjAKJ25aE+JgIj2izYLal
B1AzToq8YmAHJcFne6FJX3n2DUPKJ0BahvOkGjos9/jJjJdMI0bZw1x/As0ea6ZO
NPKgewt5F7/uyhFe+B4wyi9xCgamR/ICGwS/K/ooIxB6rs+M17bb+PiV6QbX1DV4
imnvmPivTmbhQ/mGMM6c
=+vhz
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-09-19 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 19:54 [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition Rob Herring
2013-09-09 14:06 ` Wolfgang Denk
2013-09-09 15:02 ` Rob Herring
2013-09-09 15:41 ` Wolfgang Denk
2013-09-19 19:06 ` Tom Rini
2013-09-19 21:02 ` Rob Herring
2013-09-19 22:13 ` Tom Rini [this message]
2013-09-21 20:03 ` [U-Boot] [PATCH v2] " Rob Herring
2013-10-04 13:40 ` [U-Boot] [PATCH v3 0/3] Consolidate " Rob Herring
2013-10-04 13:40 ` [U-Boot] [PATCH v3 1/3] config: consolidate " Rob Herring
2013-10-04 13:40 ` [U-Boot] [PATCH v3 2/3] config: remove platform CONFIG_SYS_HZ definition part 1/2 Rob Herring
2013-10-04 13:40 ` [U-Boot] [PATCH v3 3/3] config: remove platform CONFIG_SYS_HZ definition part 2/2 Rob Herring
2013-11-04 21:31 ` [U-Boot] [PATCH v3 0/3] Consolidate CONFIG_SYS_HZ definition Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B7701.3080606@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox