From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 19 Sep 2013 18:13:21 -0400 Subject: [U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition In-Reply-To: References: <1378670088-17602-1-git-send-email-robherring2@gmail.com> <20130909140629.4614D380DE2@gemini.denx.de> <522DE2FF.2080001@gmail.com> <20130909154146.532CB380E12@gemini.denx.de> <20130919190622.GA5273@bill-the-cat> Message-ID: <523B7701.3080606@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/19/2013 05:02 PM, Rob Herring wrote: > On Thu, Sep 19, 2013 at 2:06 PM, Tom Rini wrote: >> On Mon, Sep 09, 2013 at 05:41:46PM +0200, Wolfgang Denk wrote: >>> Dear Rob, >>> >>> In message <522DE2FF.2080001@gmail.com> you wrote: >>>> >>>> What do I do with current boards that are wrong? I should make all these >>> >>> Good question... >>> >>>> boards have build errors or fix them to use 1000 which may break them at >>>> runtime depending on their possible misuse of CONFIG_SYS_HZ? >>>> >>>> include/configs/KAREF.h:#define CONFIG_SYS_HZ 100 >>>> /* decr freq: 1 ms ticks */ >>>> include/configs/M5271EVB.h:#define CONFIG_SYS_HZ >>>> 1000000 >>>> include/configs/METROBOX.h:#define CONFIG_SYS_HZ >>>> 100 /* decr freq: 1 ms ticks */ >>>> include/configs/MVBLUE.h:#define CONFIG_SYS_HZ 10000 >>>> include/configs/idmr.h:#define CONFIG_SYS_HZ >>>> (50000000 / 64) >>>> include/configs/mini2440.h:#define CONFIG_SYS_HZ >>>> 1562500 >>>> include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 >>>> include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ >>>> ((V_SCLK) / (2 << CONFIG_SYS_PTV)) >>>> include/configs/omap730p2.h:#define CONFIG_SYS_HZ >>>> ((CONFIG_SYS_CLK_FREQ)/(2 << CONFIG_SYS_PTV)) >>>> include/configs/rsk7203.h:#define CONFIG_SYS_HZ >>>> (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) >>>> include/configs/rsk7264.h:#define CONFIG_SYS_HZ >>>> (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) >>>> include/configs/rsk7269.h:#define CONFIG_SYS_HZ >>>> (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) >>>> include/configs/scb9328.h:#define CONFIG_SYS_HZ 3686400 >>>> /* incrementer freq: 3.6864 MHz */ >>>> include/configs/versatile.h:#define CONFIG_SYS_HZ >>>> (1000000 / 256) >>> >>> Hm... which of these boards are actually still being maintained? >>> >>> KAREF and METROBOX are PPC systems, and the comment suggests that the >>> value is actually just a typo. Here it should be harmless to change >>> this to use 1000 Hz instead. Ditto probably for MVBLUE. The rest >>> might actually be dead? >>> >>> Guess we should have their builds break and make the board maintainers >>> fix them. If they don't (because the boards are unmaintained), we >>> will drop the board code from the repo. >> >> Actually breaking them will cause hell on the folks building everything. >> Lets correct the ones we can correct easily and poke maintainers for the >> rest so we know what we can/should move to orphaned or just drop. > > How about just a warning instead? Here's an updated list which missed some: > > include/configs/M5271EVB.h:#define CONFIG_SYS_HZ 1000000 > include/configs/balloon3.h:#define CONFIG_SYS_HZ > 3250000 /* Timer @ 3250000 Hz */ > include/configs/idmr.h:#define CONFIG_SYS_HZ (50000000 / 64) > include/configs/mini2440.h:#define CONFIG_SYS_HZ 1562500 > include/configs/mx1ads.h:#define CONFIG_SYS_HZ 3686400 > include/configs/omap3_zoom2.h:#define CONFIG_SYS_HZ > ((V_SCLK) / (2 << CONFIG_SYS_PTV)) > include/configs/omap730p2.h:#define CONFIG_SYS_HZ > ((CONFIG_SYS_CLK_FREQ)/(2 << CONFIG_SYS_PTV)) > include/configs/palmld.h:#define CONFIG_SYS_HZ > 3250000 /* Timer @ 3250000 Hz */ > include/configs/palmtc.h:#define CONFIG_SYS_HZ > 3686400 /* Timer @ 3686400 Hz */ > include/configs/rsk7203.h:#define CONFIG_SYS_HZ > (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) > include/configs/rsk7264.h:#define CONFIG_SYS_HZ > (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) > include/configs/rsk7269.h:#define CONFIG_SYS_HZ > (CONFIG_SYS_CLK_FREQ / CMT_CLK_DIVIDER) > include/configs/scb9328.h:#define CONFIG_SYS_HZ > 3686400 /* incrementer freq: 3.6864 MHz */ > include/configs/versatile.h:#define CONFIG_SYS_HZ > (1000000 / 256) > include/configs/zipitz2.h:#define CONFIG_SYS_HZ > 3250000 /* Timer @ 3250000 Hz */ I could live with that I think. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSO3cBAAoJENk4IS6UOR1W0I4P/0l+rxS4C6tiFmCIQo9Wtf2i owKufT+cvGsQCtzbH84g3gUR/0bLE+FTAslYLyZ8DptFqlpOnOtc+pHqlOVgWZAp R1mZyVz1jU+8bRkieDFb6tv6PFGcXAkcC37epKlVk6b9A0vJnm6xEXQ1Hwb7XGhG j5DZ8KeUXWYyGcn5SYY5wRMztWcfQMMZ8MQVbioD8LE2vh7E2QnWBio168yfUS8l rbvxoykj6fxikYCWcdlr7ov7adzCa+nmwc4u0qxXzXro5Nm0uZ98FnJSj0HmuaS0 ISG0VMO+E6BnBFOBhwYbAgKgSFvTdxM8yo5lU66UuzVwVYvqqANbHhAR0I+8e4v4 k8jlouvUcFuQycWAotZopfqPnHMpDx51UYEjIcgw+MvCc9KqIH07epDOKuq4TLgn tGrM2N6HyX+ofKjKB1r6zRrqECzbGu8E5fAZNf/JrNgUTbfFRhmMvLFJ7F99ZUb+ chjveTUsY2yCmadgwxrQjOTLBn9MCabFqkm/mGweN+EjjAKJ25aE+JgIj2izYLal B1AzToq8YmAHJcFne6FJX3n2DUPKJ0BahvOkGjos9/jJjJdMI0bZw1x/As0ea6ZO NPKgewt5F7/uyhFe+B4wyi9xCgamR/ICGwS/K/ooIxB6rs+M17bb+PiV6QbX1DV4 imnvmPivTmbhQ/mGMM6c =+vhz -----END PGP SIGNATURE-----