From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] arm: rmobile: Add support lager board
Date: Fri, 20 Sep 2013 09:11:37 +0900 [thread overview]
Message-ID: <523B92B9.9030407@renesas.com> (raw)
In-Reply-To: <20130919110419.0142bf8a@lilith>
Hi, Albert.
(2013/09/19 18:04), Albert ARIBAUD wrote:
> Hi Nobuhiro,
>
> On Thu, 22 Aug 2013 13:23:28 +0900, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.yj@renesas.com> wrote:
>
>> diff --git a/arch/arm/include/asm/mach-types.h b/arch/arm/include/asm/mach-types.h
>> index 440b041..67b88ad 100644
>> --- a/arch/arm/include/asm/mach-types.h
>> +++ b/arch/arm/include/asm/mach-types.h
>> @@ -1106,6 +1106,7 @@ extern unsigned int __machine_arch_type;
>> #define MACH_TYPE_OMAP5_SEVM 3777
>> #define MACH_TYPE_ARMADILLO_800EVA 3863
>> #define MACH_TYPE_KZM9G 4140
>> +#define MACH_TYPE_LAGER 4538
>
> Do not modify mach-types.h; if the machine type was reserved but is
> not yet in machine-types, then you should define the machine type in the
> board's header file, possibly with preprocessing directives to #error
> when the same definition appears in mach-types.h making the board's
> one obsolete.
OK, I will remove this from patch.
>
>> diff --git a/boards.cfg b/boards.cfg
>> index be810c7..8e38d3c 100644
>> --- a/boards.cfg
>> +++ b/boards.cfg
>> @@ -341,6 +341,8 @@ u8500_href arm armv7 u8500 st-eric
>> snowball arm armv7 snowball st-ericsson u8500
>> kzm9g arm armv7 kzm9g kmc rmobile
>> armadillo-800eva arm armv7 armadillo-800eva atmark-techno rmobile
>> +lager arm armv7 lager renesas rmobile
>> +lager_nor arm armv7 lager renesas rmobile lager:NORFLASH
>
> Please rebase as boards.cfg has changed, and do add maintainer
> addresses to these two lines.
>
I see.
I will update my patches and re-send.
Thank you for your review!
> Amicalement,
Best regards,
Nobuhiro
prev parent reply other threads:[~2013-09-20 0:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 4:23 [U-Boot] [PATCH 1/3] serial: sh: Add support R8A7790 Nobuhiro Iwamatsu
2013-08-22 4:23 ` [U-Boot] [PATCH 2/3] arm: rmobile: Add support r8a7790 Nobuhiro Iwamatsu
2013-08-22 4:23 ` [U-Boot] [PATCH 3/3] arm: rmobile: Add support lager board Nobuhiro Iwamatsu
2013-09-19 9:04 ` Albert ARIBAUD
2013-09-20 0:11 ` Nobuhiro Iwamatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B92B9.9030407@renesas.com \
--to=nobuhiro.iwamatsu.yj@renesas.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox