From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Date: Fri, 20 Sep 2013 09:11:37 +0900
Subject: [U-Boot] [PATCH 3/3] arm: rmobile: Add support lager board
In-Reply-To: <20130919110419.0142bf8a@lilith>
References: <1377145408-30094-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
	<1377145408-30094-3-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
	<20130919110419.0142bf8a@lilith>
Message-ID: <523B92B9.9030407@renesas.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi, Albert.

(2013/09/19 18:04), Albert ARIBAUD wrote:
> Hi Nobuhiro,
>
> On Thu, 22 Aug 2013 13:23:28 +0900, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.yj@renesas.com>  wrote:
>
>> diff --git a/arch/arm/include/asm/mach-types.h b/arch/arm/include/asm/mach-types.h
>> index 440b041..67b88ad 100644
>> --- a/arch/arm/include/asm/mach-types.h
>> +++ b/arch/arm/include/asm/mach-types.h
>> @@ -1106,6 +1106,7 @@ extern unsigned int __machine_arch_type;
>>   #define MACH_TYPE_OMAP5_SEVM           3777
>>   #define MACH_TYPE_ARMADILLO_800EVA     3863
>>   #define MACH_TYPE_KZM9G                4140
>> +#define MACH_TYPE_LAGER                4538
>
> Do not modify mach-types.h; if the machine type was reserved but is
> not yet in machine-types, then you should define the machine type in the
> board's header file, possibly with preprocessing directives to #error
> when the same definition appears in mach-types.h making the board's
> one obsolete.

OK, I will remove this from patch.

>
>> diff --git a/boards.cfg b/boards.cfg
>> index be810c7..8e38d3c 100644
>> --- a/boards.cfg
>> +++ b/boards.cfg
>> @@ -341,6 +341,8 @@ u8500_href                   arm         armv7       u8500               st-eric
>>   snowball                     arm         armv7       snowball               st-ericsson    u8500
>>   kzm9g                        arm         armv7       kzm9g               kmc            rmobile
>>   armadillo-800eva             arm         armv7       armadillo-800eva    atmark-techno  rmobile
>> +lager                        arm         armv7       lager               renesas        rmobile
>> +lager_nor                    arm         armv7       lager               renesas        rmobile     lager:NORFLASH
>
> Please rebase as boards.cfg has changed, and do add maintainer
> addresses to these two lines.
>

I see.
I will update my patches and re-send.
Thank you for your review!

> Amicalement,

Best regards,
   Nobuhiro