public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] i.MX6SL pad declarations (was [RFC PATCH 4/3] i.MX6DQ/DLS: remove unused pad declarations)
Date: Fri, 20 Sep 2013 07:42:33 -0700	[thread overview]
Message-ID: <523C5ED9.4050004@boundarydevices.com> (raw)
In-Reply-To: <20130920084416.GA13620@S2101-09.ap.freescale.net>

Thanks Shawn,

I noticed that Otavio's e-mail had a bad reference for the list,
and we've veered off the original topic.

On 09/20/2013 01:44 AM, Shawn Guo wrote:
> On Thu, Sep 19, 2013 at 07:08:35AM -0700, Eric Nelson wrote:
>> There are currently 8 pads defined in U-Boot that aren't defined
>> in the Linux kernel sources:
>>
>> 	SD2_CLK__USDHC2_CLK
>> 	SD2_CMD__USDHC2_CMD
>> 	SD2_DAT0__USDHC2_DAT0
>> 	SD2_DAT1__USDHC2_DAT1
>> 	SD2_DAT2__USDHC2_DAT2
>> 	SD2_DAT3__USDHC2_DAT3
>
> They are the following ones in kernel.
>
> 	MX6QDL_PAD_SD2_CLK__SD2_CLK
> 	MX6QDL_PAD_SD2_CMD__SD2_CMD
> 	MX6QDL_PAD_SD2_DAT0__SD2_DATA0
> 	MX6QDL_PAD_SD2_DAT1__SD2_DATA1
> 	MX6QDL_PAD_SD2_DAT2__SD2_DATA2
> 	MX6QDL_PAD_SD2_DAT3__SD2_DATA3
>
This comment was about SL, not DQ or DLS.

And my comments were wrong.

I used a tool to do a quick comparison and didn't check my work.

The reality is that U-Boot's pad declarations for SL are
almost non-existent:
	http://git.denx.de/u-boot.git/?p=u-boot.git;a=blob;f=arch/arm/include/asm/arch-mx6/mx6sl_pins.h;h=b39a354f39568b11ea010ae08485ded610b00f1a;hb=HEAD

The 8 declarations that are present all have name mis-matches
with the Linux kernel (USDHC2 vs. SD2, UART1_RXD vs. UART1_RX_DATA).

> They are named per IOMUXC registers description in reference manual.
>
>> 	UART1_RXD__UART1_RXD
>> 	UART1_TXD__UART1_TXD
>
> Yes, kernel does not define them.  That's because the reference manual
> does not define them.  The macros in kernel are generated from reference
> manual data source.
>
Cool. Thanks for your work on the kernel side. Things there
are in much better shape than in the U-Boot source tree.

Regards,


Eric

       reply	other threads:[~2013-09-20 14:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1379528046-21560-1-git-send-email-eric.nelson@boundarydevices.com>
     [not found] ` <CAP9ODKpE=p+kw+USXts03zhgUFL2QAHz0=RhOQp2c9ZR80fU8w@mail.gmail.com>
     [not found]   ` <5239FC87.6050500@boundarydevices.com>
     [not found]     ` <CAP9ODKowCdG8xYPm8yDyqt+OdK5AJfH7XSD3pobo2B1RAhk5yQ@mail.gmail.com>
     [not found]       ` <523B0563.4050706@boundarydevices.com>
     [not found]         ` <20130920084416.GA13620@S2101-09.ap.freescale.net>
2013-09-20 14:42           ` Eric Nelson [this message]
2013-10-04 23:23     ` [U-Boot] [RFC PATCH 4/3] i.MX6DQ/DLS: remove unused pad declarations Eric Nelson
     [not found]     ` <524F4A9F.4080102@boundarydevices.com>
     [not found]       ` <5256BCEE.6010002@denx.de>
     [not found]         ` <5256C7EB.6060105@boundarydevices.com>
     [not found]           ` <CAOMZO5Cagnz0g79fdzFHHGARS=MQ58epd08+0YAe8qz8vT2P8A@mail.gmail.com>
2013-10-10 15:35             ` Fabio Estevam
2013-10-11  2:10               ` Shawn Guo
2013-10-11  2:39                 ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523C5ED9.4050004@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox