* [U-Boot] [PATCH 1/2] mx6sabresd: Return error if cpu_eth_init() fails
@ 2013-09-13 1:03 Fabio Estevam
2013-09-13 1:03 ` [U-Boot] [PATCH 2/2] mx6qsabreauto: " Fabio Estevam
2013-09-20 16:05 ` [U-Boot] [PATCH 1/2] mx6sabresd: " Stefano Babic
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2013-09-13 1:03 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
Currently board_eth_init() always return 0, but we should propagate the error
when cpu_eth_init() fails.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index c832bd9..425f734 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -421,7 +421,7 @@ int board_eth_init(bd_t *bis)
if (ret)
printf("FEC MXC: %s:failed\n", __func__);
- return 0;
+ return ret;
}
int board_early_init_f(void)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 2/2] mx6qsabreauto: Return error if cpu_eth_init() fails
2013-09-13 1:03 [U-Boot] [PATCH 1/2] mx6sabresd: Return error if cpu_eth_init() fails Fabio Estevam
@ 2013-09-13 1:03 ` Fabio Estevam
2013-09-20 16:07 ` Stefano Babic
2013-09-20 16:05 ` [U-Boot] [PATCH 1/2] mx6sabresd: " Stefano Babic
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2013-09-13 1:03 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
Currently board_eth_init() always return 0, but we should propagate the error
when cpu_eth_init() fails.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/mx6qsabreauto/mx6qsabreauto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/mx6qsabreauto/mx6qsabreauto.c b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
index 1cdf2cb..c55ee87 100644
--- a/board/freescale/mx6qsabreauto/mx6qsabreauto.c
+++ b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
@@ -200,7 +200,7 @@ int board_eth_init(bd_t *bis)
if (ret)
printf("FEC MXC: %s:failed\n", __func__);
- return 0;
+ return ret;
}
#define BOARD_REV_B 0x200
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 2/2] mx6qsabreauto: Return error if cpu_eth_init() fails
2013-09-13 1:03 ` [U-Boot] [PATCH 2/2] mx6qsabreauto: " Fabio Estevam
@ 2013-09-20 16:07 ` Stefano Babic
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2013-09-20 16:07 UTC (permalink / raw)
To: u-boot
On 13/09/2013 03:03, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Currently board_eth_init() always return 0, but we should propagate the error
> when cpu_eth_init() fails.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks!
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/2] mx6sabresd: Return error if cpu_eth_init() fails
2013-09-13 1:03 [U-Boot] [PATCH 1/2] mx6sabresd: Return error if cpu_eth_init() fails Fabio Estevam
2013-09-13 1:03 ` [U-Boot] [PATCH 2/2] mx6qsabreauto: " Fabio Estevam
@ 2013-09-20 16:05 ` Stefano Babic
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2013-09-20 16:05 UTC (permalink / raw)
To: u-boot
On 13/09/2013 03:03, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Currently board_eth_init() always return 0, but we should propagate the error
> when cpu_eth_init() fails.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks!
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-20 16:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-13 1:03 [U-Boot] [PATCH 1/2] mx6sabresd: Return error if cpu_eth_init() fails Fabio Estevam
2013-09-13 1:03 ` [U-Boot] [PATCH 2/2] mx6qsabreauto: " Fabio Estevam
2013-09-20 16:07 ` Stefano Babic
2013-09-20 16:05 ` [U-Boot] [PATCH 1/2] mx6sabresd: " Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox