From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 20 Sep 2013 18:11:23 +0200 Subject: [U-Boot] [PATCH v2] net: fec_mxc: Fix timeouts during tftp transfer In-Reply-To: <1379470390-19279-1-git-send-email-festevam@gmail.com> References: <1379470390-19279-1-git-send-email-festevam@gmail.com> Message-ID: <523C73AB.6010609@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 18/09/2013 04:13, Fabio Estevam wrote: > From: Fabio Estevam > > Performing tftp transfers on mx28 results in random timeouts. > > Hector Palacios and Robert Hodaszi analyzed the root cause being related to the > wrong alignment of the 'buff' buffer inside fec_recv(). > > Beno?t Th?baudeau provided an excellent analysis of the alignment bug that is > present on older versions, such as GCC 4.5.4: > > http://marc.info/?l=u-boot&m=137942904906131&w=2 > > Use ALLOC_CACHE_ALIGN_BUFFER() to avoid alignment issues from older GCC > versions. > > Reported-by: Hector Palacios > Tested-by: Oliver Metz > Tested-by: Hector Palacios > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================