From mboxrd@z Thu Jan  1 00:00:00 1970
From: Troy Kisky <troy.kisky@boundarydevices.com>
Date: Fri, 20 Sep 2013 11:46:13 -0700
Subject: [U-Boot] [PATCH V4 06/17] usb: udc: add udc.h include file
In-Reply-To: <201309201255.40660.marex@denx.de>
References: <1379647780-2623-1-git-send-email-troy.kisky@boundarydevices.com>
	<1379647780-2623-7-git-send-email-troy.kisky@boundarydevices.com>
	<201309201255.40660.marex@denx.de>
Message-ID: <523C97F5.1040308@boundarydevices.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 9/20/2013 3:55 AM, Marek Vasut wrote:
> Dear Troy Kisky,
>
>> Move common definitions to udc.h
>> This allows musb_udc.h to be removed as well.
>>
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>>
>> ---
>> v4: updated commit message
>> removed ifdef UDC_BULK_HS_PACKET_SIZE since 512
>> is the only legal value, it shouldn't be overridden.
> [...]
>
>>   #endif
>> diff --git a/include/usb/udc.h b/include/usb/udc.h
>> new file mode 100644
>> index 0000000..3bcbbbc
>> --- /dev/null
>> +++ b/include/usb/udc.h
>> @@ -0,0 +1,61 @@
>> +/*
>> + * SPDX-License-Identifier:	GPL-2.0+
>> + */
>> +#ifndef USB_UDC_H
>> +#define USB_UDC_H
>> +
>> +#ifndef EP0_MAX_PACKET_SIZE
>> +#define EP0_MAX_PACKET_SIZE     64
>> +#endif
>> +
>> +#ifndef EP_MAX_PACKET_SIZE
>> +#define EP_MAX_PACKET_SIZE	64
>> +#endif
>> +
>> +#ifndef UDC_OUT_PACKET_SIZE
>> +#define UDC_OUT_PACKET_SIZE     EP_MAX_PACKET_SIZE
>> +#endif
>> +
>> +#ifndef UDC_IN_PACKET_SIZE
>> +#define UDC_IN_PACKET_SIZE      EP_MAX_PACKET_SIZE
>> +#endif
>> +
>> +#ifndef UDC_INT_PACKET_SIZE
>> +#define UDC_INT_PACKET_SIZE     EP_MAX_PACKET_SIZE
>> +#endif
>> +
>> +#ifndef UDC_BULK_PACKET_SIZE
>> +#define UDC_BULK_PACKET_SIZE    EP_MAX_PACKET_SIZE
>> +#endif
> Do you expect these values to change on per-controller basis? Or why do you have
> these ifndefs here ?

I don't know why they change but

include/usb/mpc8xx_udc.h:#define UDC_BULK_PACKET_SIZE 
EP_MIN_PACKET_SIZE    /* 8 */
include/usb/omap1510_udc.h:#define UDC_BULK_PACKET_SIZE 16

include/usb/mpc8xx_udc.h:#define UDC_INT_PACKET_SIZE 
UDC_IN_PACKET_SIZE   /* 8 */
include/usb/omap1510_udc.h:#define UDC_INT_PACKET_SIZE  16

include/usb/mpc8xx_udc.h:#define UDC_OUT_PACKET_SIZE 
EP_MIN_PACKET_SIZE    /* */

>> +#define UDC_BULK_HS_PACKET_SIZE	512
>> +
>> +#ifndef UDC_INT_ENDPOINT
>> +#define UDC_INT_ENDPOINT	1
>> +#endif
>> +
>> +#ifndef UDC_OUT_ENDPOINT
>> +#define UDC_OUT_ENDPOINT	2
>> +#endif
>> +
>> +#ifndef UDC_IN_ENDPOINT
>> +#define UDC_IN_ENDPOINT		3
>> +#endif
> [...]
>
> Best regards,
> Marek Vasut
>