From: Jens Scharsig <esw@bus-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] i2c_reloc_fixup fails on m68k
Date: Mon, 23 Sep 2013 15:50:50 +0200 [thread overview]
Message-ID: <5240473A.2040208@bus-elektronik.de> (raw)
Hello,
I have a access violation problem with i2c_reloc_fixup on coldfire
m68k systems.
I found out, the i2c_reloc_fixup tries to relocate the adapter itself,
but at this time i2c_adap_p is already relocated.
Can anybody confirm this?
I think also m68k, backfin and nds32 systems are affected
regards
Jens
---
diff --git a/drivers/i2c/i2c_core.c b/drivers/i2c/i2c_core.c
index d1072e8..bb5d4db 100644
--- a/drivers/i2c/i2c_core.c
+++ b/drivers/i2c/i2c_core.c
@@ -53,10 +53,6 @@ void i2c_reloc_fixup(void)
return;
for (i = 0; i < max; i++) {
- /* adapter itself */
- addr = (unsigned long)i2c_adap_p;
- addr += gd->reloc_off;
- i2c_adap_p = (struct i2c_adapter *)addr;
/* i2c_init() */
addr = (unsigned long)i2c_adap_p->init;
addr += gd->reloc_off;
next reply other threads:[~2013-09-23 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 13:50 Jens Scharsig [this message]
2013-09-24 6:33 ` [U-Boot] [RFC] i2c_reloc_fixup fails on m68k Heiko Schocher
2013-09-24 7:41 ` Jens Scharsig
2013-10-14 5:51 ` Heiko Schocher
2013-10-14 7:50 ` Jens Scharsig
2013-10-14 17:40 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5240473A.2040208@bus-elektronik.de \
--to=esw@bus-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox