public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Steven Falco <stevenfalco@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Prevent a U-Boot crash on Wandboard
Date: Mon, 23 Sep 2013 19:23:44 -0400	[thread overview]
Message-ID: <5240CD80.7070904@gmail.com> (raw)
In-Reply-To: <20130923204435.6637A380635@gemini.denx.de>

On 09/23/2013 04:44 PM, Wolfgang Denk wrote:
> Dear Tom,
>
> In message <20130923194554.GA5273@bill-the-cat> you wrote:
>>
>> So, I went off an modified cmd_pxe.c to pass around cmdtp so that we get
>> an error message out, and it's not too bad looking, but it highlights
>> another problem, which is that we could really use a way to get at least
>> the "is this a ... ?" code, and just get the error code, rather than
>> printouts.  The pxe (and really it's the syslinux.conf/extlinux.conf
>> parsing) code shouldn't be doing bootm();bootz() but checking the image
>> type and calling the right boot.
>
> Ah, full ACK  (I should have read the thread to end before posting).
>
> Thanks!
>
> Best regards,
>
> Wolfgang Denk
>

I understand your point that it is better to fix the problem at the
source.

I also like Tom's suggestion that the type be checked earlier, and
then just directly choose the right bootX() variant.

So naturally, I withdraw my patch, in favor of your fix - at least I
was able to isolate the source of the crash for you. :-)

	Steve

  reply	other threads:[~2013-09-23 23:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23  1:21 [U-Boot] [PATCH] Prevent a U-Boot crash on Wandboard Steven Falco
2013-09-23 11:40 ` Otavio Salvador
2013-09-23 18:47   ` Wolfgang Denk
2013-09-23 16:11 ` Albert ARIBAUD
2013-09-23 16:21   ` Fabio Estevam
2013-09-23 18:18     ` Tom Rini
2013-09-23 18:50     ` Wolfgang Denk
2013-09-23 19:17       ` Tom Rini
2013-09-23 19:45         ` Tom Rini
2013-09-23 20:44           ` Wolfgang Denk
2013-09-23 23:23             ` Steven Falco [this message]
2013-09-23 20:43         ` Wolfgang Denk
2013-09-23 18:45 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5240CD80.7070904@gmail.com \
    --to=stevenfalco@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox