From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Falco Date: Mon, 23 Sep 2013 19:23:44 -0400 Subject: [U-Boot] [PATCH] Prevent a U-Boot crash on Wandboard In-Reply-To: <20130923204435.6637A380635@gemini.denx.de> References: <523F979C.1070205@gmail.com> <20130923181158.0c1747f5@lilith> <20130923185055.95383380635@gemini.denx.de> <20130923191757.GZ5273@bill-the-cat> <20130923194554.GA5273@bill-the-cat> <20130923204435.6637A380635@gemini.denx.de> Message-ID: <5240CD80.7070904@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/23/2013 04:44 PM, Wolfgang Denk wrote: > Dear Tom, > > In message <20130923194554.GA5273@bill-the-cat> you wrote: >> >> So, I went off an modified cmd_pxe.c to pass around cmdtp so that we get >> an error message out, and it's not too bad looking, but it highlights >> another problem, which is that we could really use a way to get at least >> the "is this a ... ?" code, and just get the error code, rather than >> printouts. The pxe (and really it's the syslinux.conf/extlinux.conf >> parsing) code shouldn't be doing bootm();bootz() but checking the image >> type and calling the right boot. > > Ah, full ACK (I should have read the thread to end before posting). > > Thanks! > > Best regards, > > Wolfgang Denk > I understand your point that it is better to fix the problem at the source. I also like Tom's suggestion that the type be checked earlier, and then just directly choose the right bootX() variant. So naturally, I withdraw my patch, in favor of your fix - at least I was able to isolate the source of the crash for you. :-) Steve