public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Markus Niebel <list-09@tqsc.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: arch-mx6: fix PLL2_PFD2_FREQ
Date: Wed, 25 Sep 2013 09:24:04 +0200	[thread overview]
Message-ID: <52428F94.3080604@tqsc.de> (raw)
In-Reply-To: <1379687566495-163654.post@n7.nabble.com>

Hello Pierre,

Am 20.09.2013 16:32, wrote Pierre Aubert:
> Stefano Babic wrote
>> On 11/09/2013 15:30, Markus Niebel wrote:
>>> From: Markus Niebel &lt;
> 
>> Markus.Niebel@
> 
>> &gt;
>>>
>>> according to the manual frequency of PLL2 PFD2 is 396.000.000
>>> instead of 400.000.000
>>>
>>> Signed-off-by: Markus Niebel &lt;
> 
>> Markus.Niebel@
> 
>> &gt;
>>> ---
>>>  arch/arm/include/asm/arch-mx6/crm_regs.h |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/include/asm/arch-mx6/crm_regs.h
>>> b/arch/arm/include/asm/arch-mx6/crm_regs.h
>>> index 74aefe6..2813593 100644
>>> --- a/arch/arm/include/asm/arch-mx6/crm_regs.h
>>> +++ b/arch/arm/include/asm/arch-mx6/crm_regs.h
>>> @@ -892,7 +892,7 @@ struct mxc_ccm_reg {
>>>  
>>>  #define PLL2_PFD0_FREQ		352000000
>>>  #define PLL2_PFD1_FREQ		594000000
>>> -#define PLL2_PFD2_FREQ		400000000
>>> +#define PLL2_PFD2_FREQ		396000000
>>>  #define PLL2_PFD2_DIV_FREQ	200000000
>>>  #define PLL3_PFD0_FREQ		720000000
>>>  #define PLL3_PFD1_FREQ		540000000
>>>
>>
>> Acked-by: Stefano Babic &lt;
> 
>> sbabic@
> 
>> &gt;
> 
> Hello Markus, Hello Stephano
> I think it's better to compute  this frequencies rather than hard coding
> values. The default PFD frequencies are not the same for the Quad and for
> the other Socs.

As far as I read the manual for i.MX6Q/D and i.MX6DL/S have the same default values.

> Furthermore, if you modify PLL2_PFD2_FREQ, you must also change
> PLL2_PFD2_DIV_FREQ.
> 
> Please, see the patch I've submitted yesterday ([PATCH V2] mx6: compute PLL
> PFD frequencies rather than using defines)
> 

Hmm. Sounds reasonable.Do you expect any side effects?
(We came accross the mismatch that was fixed with my original 
patch when looking over DRAM configuration)
 

> Best regards
> 
> 
> 
> 
> --
> View this message in context: http://u-boot.10912.n7.nabble.com/PATCH-ARM-arch-mx6-fix-PLL2-PFD2-FREQ-tp162976p163654.html
> Sent from the U-Boot mailing list archive at Nabble.com.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 

  reply	other threads:[~2013-09-25  7:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 13:30 [U-Boot] [PATCH] ARM: arch-mx6: fix PLL2_PFD2_FREQ Markus Niebel
2013-09-11 13:30 ` [U-Boot] [PATCH] ARM: i.MX6: add i.MX6D to detected variants Markus Niebel
2013-09-20 13:53 ` [U-Boot] [PATCH] ARM: arch-mx6: fix PLL2_PFD2_FREQ Stefano Babic
2013-09-20 14:32   ` Pierre Aubert
2013-09-25  7:24     ` Markus Niebel [this message]
2013-09-25  7:38       ` Pierre AUBERT
2013-10-10 15:09     ` Stefano Babic
2013-09-20 16:02 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52428F94.3080604@tqsc.de \
    --to=list-09@tqsc.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox