From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mateusz Zalega Date: Wed, 25 Sep 2013 13:01:02 +0200 Subject: [U-Boot] [PATCH v4] usb: new board-specific USB init interface In-Reply-To: <201309191634.14207.marex@denx.de> References: <1375786242-11734-1-git-send-email-m.zalega@samsung.com> <201309191534.53502.marex@denx.de> <201309191540.51675.marex@denx.de> <201309191634.14207.marex@denx.de> Message-ID: <5242C26E.2050003@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/19/13 16:34, Marek Vasut wrote: > I checked powerpc and "arches" "glacier" and "glacier_nand" don't build. Can you > please check and fix ? You can get the ELDK 5.4 PPC toolchain from [1]. > > http://www.denx.de/wiki/ELDK-5/ Hello, it's because I moved some function declarations and had to include usb.h in their code. @usb.h, this giant ifdef fails: 134 #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \ 135 defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \ 136 defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ 137 defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \ 138 defined(CONFIG_USB_OMAP3) || defined(CONFIG_USB_DA8XX) || \ 139 defined(CONFIG_USB_BLACKFIN) || defined(CONFIG_USB_AM35X) || \ 140 defined(CONFIG_USB_MUSB_DSPS) || defined(CONFIG_USB_MUSB_AM35X) || \ 141 defined(CONFIG_USB_MUSB_OMAP2PLUS) and results in: 169 #error USB Lowlevel not defined I don't like the notion of using board-specific CONFIG_* defines in usb.h. Any ideas on where can we move it? Maybe one generic CONFIG_USB_HOST specified in board code would do? -- Mateusz Zalega Samsung R&D Institute Poland