From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vipin Kumar Date: Thu, 26 Sep 2013 09:27:42 +0530 Subject: [U-Boot] [PATCH] drivers/net/designware - respect "bus mode" register contents on SW reset In-Reply-To: <1380115990-24683-1-git-send-email-abrodkin@synopsys.com> References: <1380115990-24683-1-git-send-email-abrodkin@synopsys.com> Message-ID: <5243B0B6.5000308@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 9/25/2013 7:03 PM, Alexey Brodkin wrote: > "bus mode" register contains lots of fields and some of them don't > expect to be written with 0 (zero). So since we're only interested in > resetting MAC (which is done with setting the least significant bit of > this register with "0") I believe it's better to modify only 1 bit of > the register. > > Signed-off-by: Alexey Brodkin > --- > drivers/net/designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/designware.c b/drivers/net/designware.c > index 46f6601..f11cb0b 100644 > --- a/drivers/net/designware.c > +++ b/drivers/net/designware.c > @@ -112,7 +112,7 @@ static int mac_reset(struct eth_device *dev) > ulong start; > int timeout = CONFIG_MACRESET_TIMEOUT; > > - writel(DMAMAC_SRST,&dma_p->busmode); > + writel(readl(&dma_p->busmode) | DMAMAC_SRST,&dma_p->busmode); > Acked-by: Vipin Kumar