public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051
@ 2013-09-25 10:21 Lars Poeschel
  2013-09-25 10:21 ` [U-Boot] [PATCH 1/1] pcm051: Supply a bd_ram_ofs for the cpsw driver Lars Poeschel
  2013-09-26 16:40 ` [U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051 Mugunthan V N
  0 siblings, 2 replies; 4+ messages in thread
From: Lars Poeschel @ 2013-09-25 10:21 UTC (permalink / raw)
  To: u-boot

From: Lars Poeschel <poeschel@lemonage.de>

I compiled and tried v2013.10-rc2 on pcm051 and it fails booting over
tftp. I could bisect 2bf36ac638ab2db9f0295aa47064976eeebf80c1 as the
cause of the problem. It moves bd_ram_ofs from the cpsw driver to the
board files. Adding the bd_ram_ofs to the board file of pcm051 fixes
the problem. That is what the patch does.
A quick grep reveals, that igep0033 MAY also be affected.
As the patch is simple and obivous and fixes a regression I'd like to
get this in before the v2013.10 release.

Thanks

Lars Poeschel (1):
  pcm051: Supply a bd_ram_ofs for the cpsw driver

 board/phytec/pcm051/board.c | 1 +
 1 file changed, 1 insertion(+)

-- 
1.8.4.rc3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 1/1] pcm051: Supply a bd_ram_ofs for the cpsw driver
  2013-09-25 10:21 [U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051 Lars Poeschel
@ 2013-09-25 10:21 ` Lars Poeschel
  2013-09-26 16:40 ` [U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051 Mugunthan V N
  1 sibling, 0 replies; 4+ messages in thread
From: Lars Poeschel @ 2013-09-25 10:21 UTC (permalink / raw)
  To: u-boot

From: Lars Poeschel <poeschel@lemonage.de>

Since 2bf36ac638ab2db9f0295aa47064976eeebf80c1 the BD ram address is
not hardcoded inside cpsw driver any more. Platforms have to supply
their bd_ram_ofs in the platform data to the driver. With this
commit pcm051 does this.

Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
---
 board/phytec/pcm051/board.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/board/phytec/pcm051/board.c b/board/phytec/pcm051/board.c
index e40b0bd..dafb1eb 100644
--- a/board/phytec/pcm051/board.c
+++ b/board/phytec/pcm051/board.c
@@ -150,6 +150,7 @@ static struct cpsw_platform_data cpsw_data = {
 	.ale_entries		= 1024,
 	.host_port_reg_ofs	= 0x108,
 	.hw_stats_reg_ofs	= 0x900,
+	.bd_ram_ofs		= 0x2000,
 	.mac_control		= (1 << 5),
 	.control		= cpsw_control,
 	.host_port_num		= 0,
-- 
1.8.4.rc3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051
  2013-09-25 10:21 [U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051 Lars Poeschel
  2013-09-25 10:21 ` [U-Boot] [PATCH 1/1] pcm051: Supply a bd_ram_ofs for the cpsw driver Lars Poeschel
@ 2013-09-26 16:40 ` Mugunthan V N
  2013-09-27 18:25   ` Enric Balletbo Serra
  1 sibling, 1 reply; 4+ messages in thread
From: Mugunthan V N @ 2013-09-26 16:40 UTC (permalink / raw)
  To: u-boot

On 9/25/2013 5:21 AM, Lars Poeschel wrote:
> From: Lars Poeschel <poeschel@lemonage.de>
>
> I compiled and tried v2013.10-rc2 on pcm051 and it fails booting over
> tftp. I could bisect 2bf36ac638ab2db9f0295aa47064976eeebf80c1 as the
> cause of the problem. It moves bd_ram_ofs from the cpsw driver to the
> board files. Adding the bd_ram_ofs to the board file of pcm051 fixes
> the problem. That is what the patch does.
> A quick grep reveals, that igep0033 MAY also be affected.
> As the patch is simple and obivous and fixes a regression I'd like to
> get this in before the v2013.10 release.
>
> Thanks
>
> Lars Poeschel (1):
>   pcm051: Supply a bd_ram_ofs for the cpsw driver
>
>  board/phytec/pcm051/board.c | 1 +
>  1 file changed, 1 insertion(+)
>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>

Regards
Mugunthan V N

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051
  2013-09-26 16:40 ` [U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051 Mugunthan V N
@ 2013-09-27 18:25   ` Enric Balletbo Serra
  0 siblings, 0 replies; 4+ messages in thread
From: Enric Balletbo Serra @ 2013-09-27 18:25 UTC (permalink / raw)
  To: u-boot

Hi Lars,

2013/9/26 Mugunthan V N <mugunthanvnm@ti.com>:
> On 9/25/2013 5:21 AM, Lars Poeschel wrote:
>> From: Lars Poeschel <poeschel@lemonage.de>
>>
>> I compiled and tried v2013.10-rc2 on pcm051 and it fails booting over
>> tftp. I could bisect 2bf36ac638ab2db9f0295aa47064976eeebf80c1 as the
>> cause of the problem. It moves bd_ram_ofs from the cpsw driver to the
>> board files. Adding the bd_ram_ofs to the board file of pcm051 fixes
>> the problem. That is what the patch does.
>> A quick grep reveals, that igep0033 MAY also be affected.
>> As the patch is simple and obivous and fixes a regression I'd like to
>> get this in before the v2013.10 release.

Many thanks to detect this, as you said the igep0033 machine is also
affected for this, so this patch is required. Could you send a version
2 and add the patch for igep0033 in the series ?. You can also add my

Tested-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>

I'd like to get this series in before the v2013.10 release, too.


>>
>> Thanks
>>
>> Lars Poeschel (1):
>>   pcm051: Supply a bd_ram_ofs for the cpsw driver
>>
>>  board/phytec/pcm051/board.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
> Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
>
> Regards
> Mugunthan V N
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Regards,

    Enric

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-09-27 18:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-25 10:21 [U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051 Lars Poeschel
2013-09-25 10:21 ` [U-Boot] [PATCH 1/1] pcm051: Supply a bd_ram_ofs for the cpsw driver Lars Poeschel
2013-09-26 16:40 ` [U-Boot] [PATCH 0/1] Fix ethernet regression on pcm051 Mugunthan V N
2013-09-27 18:25   ` Enric Balletbo Serra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox