From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 26 Sep 2013 16:49:06 -0400 Subject: [U-Boot] When to create a SoC directory for ARM In-Reply-To: <1380228278.24959.304.camel@snotra.buserror.net> References: <1380223392.24959.275.camel@snotra.buserror.net> <52448F8F.9080604@freescale.com> <1380225311.24959.295.camel@snotra.buserror.net> <524491C2.4040807@freescale.com> <1380228278.24959.304.camel@snotra.buserror.net> Message-ID: <52449DC2.2020204@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/26/2013 04:44 PM, Scott Wood wrote: > On Thu, 2013-09-26 at 12:57 -0700, York Sun wrote: >> On 09/26/2013 12:55 PM, Scott Wood wrote: >>> On Thu, 2013-09-26 at 12:48 -0700, York Sun wrote: >>>> On 09/26/2013 12:46 PM, Sharma Bhupesh-B45370 wrote: >>>>> >>>>>> -----Original Message----- From: >>>>>> u-boot-bounces at lists.denx.de >>>>>> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Scott >>>>>> Wood Sent: Friday, September 27, 2013 12:53 AM To: >>>>>> FengHua Cc: trini; sun york-R58495; u-boot Subject: Re: >>>>>> [U-Boot] When to create a SoC directory for ARM >>>>>> >>>>>> On Thu, 2013-09-26 at 13:23 +0800, FengHua wrote: >>>>>>> all SOC specific include file should be in >>>>>>> arch/arm/include/asm/arch-SOC/ or some common >>>>>>> directory(like include/asm/imx-common). Currently, >>>>>>> u-boot only link SOC specific(arch-SOC) include >>>>>>> directory. You could touch a mmu.h file in >>>>>>> arch/arm/include/asm/arch-ls2/ and include >>>>>>> arch/arm/include/asm/arch-armv8/mmu.h. or move >>>>>>> arch-armv8/mmu.h to arch/arm/include/asm/ to make it as >>>>>>> a generic file. Maybe we should distinguish >>>>>>> architecture specific include directory and SOC >>>>>>> specific include directory. >>>>>> >>>>>> Is the XXX arch-XXX supposed to be an SoC family or a >>>>>> CPU family/architectutre? >>>>>> >>>>> >>>>> Usually in 'arch/arm/include/asm' we have both: - >>>>> arch-armv7 (Arch specific. Houses stuff common to ARMv7 >>>>> CPU, e.g. Global timer, SP805 WDT..) - arch-mx6 (SoC family >>>>> specific. Houses stuff like SoC specific IOMUX pads..) >>> >>> Which one does "#inculde " refer to? >>> >> >> arm/arch is a symbolic link created at compiling time. It points >> to arm/arch-$(soc), if $(soc) is not defined, then it points to >> asm/arch-$(arch). That's my understanding. > > How is that supposed to work when both arch-$(soc) and arch-$(arch) > are present? Why are SoC and CPU arch confused in this way? Primarily because it hasn't been an issue until now really. What's wrong with just saying as needed ? Or do we have a volunteer for a big re-jiggering of includes? Adding a like the kernel has would be helpful in some cases, like this. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSRJ3CAAoJENk4IS6UOR1WA7UQALKfEQBWv6KC9poxU5FWy0fF zcoT8i1YB1jsPsEnSa/QZPZJ0XLeJmJicPbctNImj1WuljMVO8cu50RTfcXgEKuX g7fLczioupYCV+2fd7FMKsG3JXG0vbLkkDTzSuFNdd4uE2awcoiKCK9LO6XK56gs /a8oS5fsPJlVPaKnvxy0xI1h2w56FtKScqUOxb4l8JpCBo/5B3FzNQ1tL1ZcG/hn Lfg09WYNUJOe0axuHE1VGIQOM8KN1d/qwZXwsPcZ8wYH+pF4kwAcg/A9TwWmvJHu VS+jz0I9wDAXyYPJEcvlDXNWOUKHjRfWLTnh4BKGPVa6jXmuq1UL1KnLBnhntxik OOsAt45mKru1VTihjqk1+1K2W7zNl100/bX1d3R902mQz/5n4t/H47DRhUa+uLOz CEdjglOASmZjnLkk8PLKOM3ZoKgJtrrePQO7xX5LPOkFytQ2AphBd1hrFLE3DG2S r3Bskj5g+FWt+c+jU+pw+P6Ct2tZFAk4uZHjnYI2sE5j0cd7P9OnR2hvEpILDUXo /Tz5sGuyBaERKKNW3965SrydetMiZZuPfQzxYczIF0ZpQaoOuHaAApyfq8VJbU4q b7frLpyvO8G/yoh4Wid6i7dQNm8FDnGWz+z+lNub9EIqSAIavIb9otFl2O6T4MvF b2sHtCcEIdjZH8SIoe/v =ETM5 -----END PGP SIGNATURE-----