public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mx6: Fix use of improper value in enable_ipu_clock
@ 2013-09-23 11:37 Pierre Aubert
  2013-09-23 17:15 ` Eric Nelson
  0 siblings, 1 reply; 3+ messages in thread
From: Pierre Aubert @ 2013-09-23 11:37 UTC (permalink / raw)
  To: u-boot

The value MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET that was used to initialize
the CCGR3 register caused an undefined value for CG0.

Signed-off-by: Pierre Aubert <p.aubert@staubli.com>
CC: Stefano Babic <sbabic@denx.de>
---
 arch/arm/cpu/armv7/mx6/clock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
index 7efb0d2..0f7bcbc 100644
--- a/arch/arm/cpu/armv7/mx6/clock.c
+++ b/arch/arm/cpu/armv7/mx6/clock.c
@@ -457,7 +457,7 @@ void enable_ipu_clock(void)
 	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
 	int reg;
 	reg = readl(&mxc_ccm->CCGR3);
-	reg |= MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET;
+	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
 	writel(reg, &mxc_ccm->CCGR3);
 }
 /***************************************************/
-- 
1.7.6.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mx6: Fix use of improper value in enable_ipu_clock
  2013-09-23 11:37 [U-Boot] [PATCH] mx6: Fix use of improper value in enable_ipu_clock Pierre Aubert
@ 2013-09-23 17:15 ` Eric Nelson
  2013-09-27 12:06   ` Stefano Babic
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Nelson @ 2013-09-23 17:15 UTC (permalink / raw)
  To: u-boot

On 09/23/2013 04:37 AM, Pierre Aubert wrote:
> The value MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET that was used to initialize
> the CCGR3 register caused an undefined value for CG0.
>
> Signed-off-by: Pierre Aubert <p.aubert@staubli.com>
> CC: Stefano Babic <sbabic@denx.de>
> ---
>   arch/arm/cpu/armv7/mx6/clock.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
> index 7efb0d2..0f7bcbc 100644
> --- a/arch/arm/cpu/armv7/mx6/clock.c
> +++ b/arch/arm/cpu/armv7/mx6/clock.c
> @@ -457,7 +457,7 @@ void enable_ipu_clock(void)
>   	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
>   	int reg;
>   	reg = readl(&mxc_ccm->CCGR3);
> -	reg |= MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET;
> +	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
>   	writel(reg, &mxc_ccm->CCGR3);
>   }
>   /***************************************************/
>

Acked-by: Eric Nelson <eric.nelson@boundarydevices.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mx6: Fix use of improper value in enable_ipu_clock
  2013-09-23 17:15 ` Eric Nelson
@ 2013-09-27 12:06   ` Stefano Babic
  0 siblings, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2013-09-27 12:06 UTC (permalink / raw)
  To: u-boot

> On 09/23/2013 04:37 AM, Pierre Aubert wrote:
>> The value MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET that was used to initialize
>> the CCGR3 register caused an undefined value for CG0.
>>
>> Signed-off-by: Pierre Aubert <p.aubert@staubli.com>
>> CC: Stefano Babic <sbabic@denx.de>
>> ---

Applied to u-boot-imx (fix), thanks!

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-27 12:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 11:37 [U-Boot] [PATCH] mx6: Fix use of improper value in enable_ipu_clock Pierre Aubert
2013-09-23 17:15 ` Eric Nelson
2013-09-27 12:06   ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox