From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] config.mk: enable -fstack-usage only when it is desired
Date: Fri, 27 Sep 2013 19:57:23 +0200 [thread overview]
Message-ID: <5245C703.6060907@myspectrum.nl> (raw)
In-Reply-To: <20130927110901.5405.AA925319@jp.panasonic.com>
Hello Masahiro,
On 09/27/2013 04:09 AM, Masahiro Yamada wrote:
>
>> The problem here is that except for whatever arches don't support
>> - -fstack-usage, we always want to generate this information, to assist in
>> debugging stack usage problems (which can be a real problem within SPL
>> for example). How about ifneq($(CONFIG_M68K)$(CONFIG_...),y) ... endif
>> around it?
> OK. This works.
>
> But I'm kind of afraid ifneq($(CONFIG_M68K)$(CONFIG_...),y) ... endif
> might be too arch-specific to be written in the top config.mk.
>
> Instead, we can add
> CONFIG_CC_STACKUSAGE=y
> to arch/{arm, powerpc, x86, microblaze ...}/config.mk
I guess below patch should work as well. Anyone aware
of any side affects it might cause?
---
Regards,
Jeroen
diff --git a/config.mk b/config.mk
index 48913f6..177f685 100644
--- a/config.mk
+++ b/config.mk
@@ -117,7 +117,7 @@ CC_TEST_OFILE :=
$(OBJTREE)/include/generated/cc_test_file.o
-include $(CC_OPTIONS_CACHE_FILE)
cc-option-sys = $(shell mkdir -p $(dir $(CC_TEST_OFILE)); \
- if $(CC) $(CFLAGS) $(1) -S -xc /dev/null -o
$(CC_TEST_OFILE) \
+ if $(CC) -Werror $(CFLAGS) $(1) -S -xc /dev/null -o
$(CC_TEST_OFILE) \
> /dev/null 2>&1; then \
echo 'CC_OPTIONS += $(strip $1)' >>
$(CC_OPTIONS_CACHE_FILE); \
echo "$(1)"; fi)
next prev parent reply other threads:[~2013-09-27 17:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 2:17 [U-Boot] [PATCH] config.mk: enable -fstack-usage only when it is desired Masahiro Yamada
2013-09-26 11:52 ` Tom Rini
2013-09-26 14:32 ` Michal Simek
2013-09-27 2:23 ` Masahiro Yamada
2013-09-27 8:13 ` Michal Simek
2013-09-27 2:09 ` Masahiro Yamada
2013-09-27 17:57 ` Jeroen Hofstee [this message]
2013-09-30 8:01 ` Masahiro Yamada
2013-10-08 19:46 ` Jeroen Hofstee
2013-10-15 10:51 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5245C703.6060907@myspectrum.nl \
--to=jeroen@myspectrum.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox