From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Fri, 27 Sep 2013 15:22:32 -0700 Subject: [U-Boot] [PATCH V5 02/18] usb: ehci-mx6: add support for host mode otg port In-Reply-To: <201309272242.21009.marex@denx.de> References: <1380159678-26416-1-git-send-email-troy.kisky@boundarydevices.com> <201309271950.54857.marex@denx.de> <5245E0DB.2040009@boundarydevices.com> <201309272242.21009.marex@denx.de> Message-ID: <52460528.6030002@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 9/27/2013 1:42 PM, Marek Vasut wrote: > } > > -static void usbh1_oc_config(void) > +struct usbnc_regs { > + u32 ctrl[4]; /* otg/host1-3 */ >>> This won't scale. Align this with the # of controllers you claim you have >>> here, why dont you? >> You've lost me here. Can you post the struct you'd like to see? > Something like u32 ctrl[CONFIG_HOW_MANY_PORTS_YOU_HAVE] or so would suffice. I > think you have such a MAX_PORTS #define already. > This structure is a description of the i.mx6 hardware. I could add the unreferenced 4 registers that are next to make this clearer?