[U-Boot] [PATCH 3/3 v6] i2c: s3c24xx: add hsi2c controller support

Heiko Schocher
2013-10-15T09:39:25Z

Hello Naveen,

Am 15.10.2013 11:34, schrieb Naveen Krishna Ch:
> On 15 October 2013 12:10, Heiko Schocher<hs@denx.de> wrote:
>> Hello Naveen,
>>
>> Am 15.10.2013 08:07, schrieb Naveen Krishna Chatradhi:
>>
>>> Add support for hsi2c controller available on exynos5420.
>>>
>>> Note: driver currently supports only fast speed mode 100kbps
>>>
>>> Change-Id: I02555b1dc8f4ac21c50aa5158179768563c92f43
>>> Signed-off-by: Naveen Krishna Chatradhi<ch.naveen@samsung.com>
>>> Signed-off-by: R. Chandrasekar<rc.sekar@samsung.com>
>>> ---
>>> Changes since v5:
>>> Fix compilation errors (undeclared CONFIG_MAX_I2C_NUM) for VCMA9 boards
>>
>>
>> :-(
>>
>> I get based on current u-boot-i2c.git and your 3 patches applied:
>>
>> [hs at pollux u-boot]$ ./MAKEALL -s s3c24x0
>> Configuring for mini2440 board...
>> text data bss dec hex filename
>> 131692 2918 23272 157882 268ba ./u-boot
>> Configuring for VCMA9 board...
>> text data bss dec hex filename
>> 505577 14742 319892 840211 cd213 ./u-boot
>> s3c24x0_i2c.c:301:12: warning: 'hsi2c_get_clk_details' defined but not used
>> [-Wunused-function]
>> Configuring for smdk2410 board...
>> text data bss dec hex filename
>> 478329 13402 319888 811619 c6263 ./u-boot
> This warning is because the CONFIG_I2C_MULTI_BUS was not defined
> and this check will be removed once this driver moves to the new I2C frame work.
>
> I thought warnings are OK, unless its obviously seriously.
>>
>>
>> bye,
>> Heiko
>
> Should i be removing that warning as well ?
> Thanks for your time and assistance.

Yes, please!

bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany