[U-Boot] [PATCH 1/3 v2] exynos: i2c: Fix i2c driver to handle NACKs properly

Heiko Schocher
2013-10-15T05:10:19Z

Hello Naveen,

Am 15.10.2013 06:48, schrieb Naveen Krishna Ch:
> On 14 October 2013 11:59, Heiko Schocher<hs@denx.de> wrote:
>> Hello Naveen,
>>
>> Am 03.10.2013 13:22, schrieb Naveen Krishna Chatradhi:
>>
>>> The Exynos5 i2c driver does not handle NACKs properly. This change:
>>>
>>> - fixes the NACK processing problem (do not continue transaction if
>>> address cycle was NACKed)
>>>
>>> - eliminates a fair amount of duplicate code
>>>
>>> Signed-off-by: Vadim Bendebury<vbendeb@chromium.org>
>>> Reviewed-by: Simon Glass<sjg@google.com>
>>> Signed-off-by: Naveen Krishna Chatradhi<ch.naveen@samsung.com>
>>> ---
>>> Changes since v1:
>>> 1. Removed the compilation error mentioned by Heiko for VCMA9 board...
>>
>>
>> Hmm.. just tried your patchset and I get for the VCMA9 board:
>>
>> http://patchwork.ozlabs.org/patch/280286/
>> http://patchwork.ozlabs.org/patch/280287/
>> http://patchwork.ozlabs.org/patch/280288/
>>
>>
>> Configuring for VCMA9 board...
>> s3c24x0_i2c.c:125:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not in a
>> function)
>> arm-linux-gnueabi-size: './u-boot': No such file
>> s3c24x0_i2c.c:125:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not in a
>> function)
>> s3c24x0_i2c.c:125:31: warning: 'i2c_bus' defined but not used
>> [-Wunused-variable]
>> s3c24x0_i2c.c:295:12: warning: 'hsi2c_get_clk_details' defined but not used
>> [-Wunused-function]
>> make[1]: *** [s3c24x0_i2c.o] Fehler 1
>> make: *** [drivers/i2c/libi2c.o] Fehler 2
>> make: *** Warte auf noch nicht beendete Prozesse...
>>
>> Could you check this complete patchset, thanks!
> Just check with "make VCMA9 -j4> err" I see the errors.
> Heiko, Whats the best way to check the compilation errors for all
> boards related to Samsung.

in U-Boot tree:

all s3c24x0 boards:
./MAKEALL -s s3c24x0

(prefered check) all arm boards:
./MAKEALL arm

> Will resubmit the patchset.

Thanks!

bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany