From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/10] arm: vf610: fix anadig register struct
Date: Mon, 30 Sep 2013 10:19:29 +0200 [thread overview]
Message-ID: <52493411.7080509@ziswiler.com> (raw)
In-Reply-To: <CAP9ODKqRbMVmOHarC-hjoohtXWuFwd4mkRbYRCPzByfJh5E3kw@mail.gmail.com>
On 09/17/2013 03:27 PM, Otavio Salvador wrote:
> I agree with the way to fix it but it is a little bit hard to get it
> is a 'reserved'; we used reserved_<where> to make it more explicit.
> Take a look at
> http://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/include/asm/arch-mxs/regs-power-mx28.h;h=9528e3ce9ad805ec30a1c0595924dbddb296c50f
> for an usage example.
At the end of the day those reserved fields are just memory holes in the
register set. I don't think they really belong to either the previous
last nor the first next valid register. Also I don't really see how the
naming convention in use at above mentioned link is much more consistent.
If we really do want do change the way this is done then probably naming
it after the actual memory offset would be most helpful (e.g.
reserved_0x014[3]). If you agree I will cook up a new patch series in
that respect.
next prev parent reply other threads:[~2013-09-30 8:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 10:45 [U-Boot] [PATCH 00/10] arm: vf610/vf610twr: vybrid tower fixes and enhancements Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 01/10] arm: vf610: fix anadig register struct Marcel Ziswiler
2013-09-17 13:27 ` Otavio Salvador
2013-09-30 8:19 ` Marcel Ziswiler [this message]
2013-09-17 10:45 ` [U-Boot] [PATCH 02/10] arm: vf610: clean-up " Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 03/10] arm: vf610: add uart0 clock definition Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 04/10] arm: vf610: add anadig pll5 definitions Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 05/10] arm: vf610: add enet1 base address definition Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 06/10] arm: vf610: add rmii clkout iomux definition Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 07/10] arm: vf610: add uart0 tx/rx iomux definitions Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 08/10] arm: vf610: add rmii1 " Marcel Ziswiler
2013-09-22 5:56 ` Wang Huan-B18965
2013-09-30 8:24 ` Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 09/10] arm: vf610: fix double iomux configuration for vf610twr board Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 10/10] arm: vf610: remove obsolete uart port configuration Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52493411.7080509@ziswiler.com \
--to=marcel@ziswiler.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox