From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Ziswiler Date: Mon, 30 Sep 2013 10:19:29 +0200 Subject: [U-Boot] [PATCH 01/10] arm: vf610: fix anadig register struct In-Reply-To: References: <86ae7d0a8914a2e3c21009b4e9eb8f3c92e343fb.1379414181.git.marcel@ziswiler.com> Message-ID: <52493411.7080509@ziswiler.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/17/2013 03:27 PM, Otavio Salvador wrote: > I agree with the way to fix it but it is a little bit hard to get it > is a 'reserved'; we used reserved_ to make it more explicit. > Take a look at > http://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/include/asm/arch-mxs/regs-power-mx28.h;h=9528e3ce9ad805ec30a1c0595924dbddb296c50f > for an usage example. At the end of the day those reserved fields are just memory holes in the register set. I don't think they really belong to either the previous last nor the first next valid register. Also I don't really see how the naming convention in use at above mentioned link is much more consistent. If we really do want do change the way this is done then probably naming it after the actual memory offset would be most helpful (e.g. reserved_0x014[3]). If you agree I will cook up a new patch series in that respect.