public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 08/10] arm: vf610: add rmii1 iomux definitions
Date: Mon, 30 Sep 2013 10:24:35 +0200	[thread overview]
Message-ID: <52493543.20908@ziswiler.com> (raw)
In-Reply-To: <81BA6E5E0BC2344391CABCEE22D1B6D843A4A7@039-SN1MPN1-003.039d.mgd.msft.net>

On 09/22/2013 07:56 AM, Wang Huan-B18965 wrote:
>> -----Original Message-----
>> From: Marcel Ziswiler [mailto:marcel at ziswiler.com]
>> Sent: Tuesday, September 17, 2013 6:45 PM
>> To: u-boot at lists.denx.de
>> Cc: Wang Huan-B18965; Marcel Ziswiler
>> Subject: [PATCH 08/10] arm: vf610: add rmii1 iomux definitions
>>
>> Add secondary RMII1 iomux definitions.
>>
>> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
>> ---
>>   arch/arm/include/asm/arch-vf610/iomux-vf610.h |    9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-vf610/iomux-vf610.h
>> b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
>> index a6f7132..1b410c3 100644
>> --- a/arch/arm/include/asm/arch-vf610/iomux-vf610.h
>> +++ b/arch/arm/include/asm/arch-vf610/iomux-vf610.h
>> @@ -36,6 +36,15 @@ enum {
>>   	VF610_PAD_PTC6__RMII0_TD1		= IOMUX_PAD(0x00cc, 0x00cc, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>>   	VF610_PAD_PTC7__RMII0_TD0		= IOMUX_PAD(0x00D0, 0x00D0, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>>   	VF610_PAD_PTC8__RMII0_TXEN		= IOMUX_PAD(0x00D4, 0x00D4, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC10__RMII1_MDIO		= IOMUX_PAD(0x00dc, 0x00b8, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC9__RMII1_MDC		= IOMUX_PAD(0x00d8, 0x00b4, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC11__RMII1_CRS_DV		= IOMUX_PAD(0x00e0, 0x00bc, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC12__RMII1_RD1		= IOMUX_PAD(0x00e4, 0x00c0, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC13__RMII1_RD0		= IOMUX_PAD(0x00e8, 0x00c4, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC14__RMII1_RXER		= IOMUX_PAD(0x00ec, 0x00c8, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC15__RMII1_TD1		= IOMUX_PAD(0x00f0, 0x00cc, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC16__RMII1_TD0		= IOMUX_PAD(0x00f4, 0x00D0, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>> +	VF610_PAD_PTC17__RMII1_TXEN		= IOMUX_PAD(0x00f8, 0x00D4, 1,
>> __NA_, 0, VF610_ENET_PAD_CTRL),
>>   	VF610_PAD_PTA24__ESDHC1_CLK		= IOMUX_PAD(0x0038, 0x0038, 5,
>> __NA_, 0, VF610_SDHC_PAD_CTRL),
>>   	VF610_PAD_PTA25__ESDHC1_CMD		= IOMUX_PAD(0x003c, 0x003c, 5,
>> __NA_, 0, VF610_SDHC_PAD_CTRL),
>>   	VF610_PAD_PTA26__ESDHC1_DAT0		= IOMUX_PAD(0x0040, 0x0040, 5,
>> __NA_, 0, VF610_SDHC_PAD_CTRL),
> [Alison Wang] For these RMII1 IOMUX definitions, the mux_ctrl_ofs parameter should be the same as pad_ctrL_ofs parameter. In this patch, the mux_ctrl_ofs are all for RMII0.
Yes, you are absolutely right. How could I have missed that one - stupid 
me. Strange that it actually worked at all.

I will cook up a new patch series shortly.

  reply	other threads:[~2013-09-30  8:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17 10:45 [U-Boot] [PATCH 00/10] arm: vf610/vf610twr: vybrid tower fixes and enhancements Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 01/10] arm: vf610: fix anadig register struct Marcel Ziswiler
2013-09-17 13:27   ` Otavio Salvador
2013-09-30  8:19     ` Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 02/10] arm: vf610: clean-up " Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 03/10] arm: vf610: add uart0 clock definition Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 04/10] arm: vf610: add anadig pll5 definitions Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 05/10] arm: vf610: add enet1 base address definition Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 06/10] arm: vf610: add rmii clkout iomux definition Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 07/10] arm: vf610: add uart0 tx/rx iomux definitions Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 08/10] arm: vf610: add rmii1 " Marcel Ziswiler
2013-09-22  5:56   ` Wang Huan-B18965
2013-09-30  8:24     ` Marcel Ziswiler [this message]
2013-09-17 10:45 ` [U-Boot] [PATCH 09/10] arm: vf610: fix double iomux configuration for vf610twr board Marcel Ziswiler
2013-09-17 10:45 ` [U-Boot] [PATCH 10/10] arm: vf610: remove obsolete uart port configuration Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52493543.20908@ziswiler.com \
    --to=marcel@ziswiler.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox