From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6: Add IOMUX_CONFIG_SION flag to all GPIO pins
Date: Tue, 01 Oct 2013 07:26:32 -0700 [thread overview]
Message-ID: <524ADB98.9010605@boundarydevices.com> (raw)
In-Reply-To: <524ACA60.3020504@denx.de>
Hi Stefano,
On 10/01/2013 06:13 AM, Stefano Babic wrote:
> Hi Otavio,
>
> On 01/10/2013 14:01, Otavio Salvador wrote:
>>> I suggest you add in the commit message that this patch is only for
>>> i.MX6 (if you do not plan to extend it to the other i.MXes...), so that
>>> we can track that the same must be done also for the other SOCs.
>>
>> I think this is clear from the commit prefix.
>
> Sorry, you're right, it is fine.
>
>>
>> I am under heavy load now and I cannot check their datasheet to verify
>> if they all need this or not.
>>
>> If someone does not does it, I can take a look for sure.
>
> I look at MX51 / MX53 manuals. They are different as i.MX6, and in both
> cases I do not read the requirement to set the SION bit, as the i.MX6
> needs. The fix is then only for i.MX6, and we do not need to extend it,
> at least according to documentation. After this check, I think that your
> patch is complete and I will push it for the release.
>
I'm not sure where you're seeing this in the RM, but in
order to read the pad state when not configured as an input,
the SION bit needs to be set in the pad mux register on i.MX51/53.
FWIW, this also works when not muxed as a GPIO, which is really
handy for verifying that a PWM is toggling, et cetera.
Regards,
Eric
next prev parent reply other threads:[~2013-10-01 14:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 22:15 [U-Boot] [PATCH] mx6: Add IOMUX_CONFIG_SION flag to all GPIO pins Otavio Salvador
2013-10-01 8:33 ` Stefano Babic
2013-10-01 12:01 ` Otavio Salvador
2013-10-01 12:43 ` Marek Vasut
2013-10-01 13:08 ` Otavio Salvador
2013-10-01 14:21 ` Eric Nelson
2013-10-01 13:13 ` Stefano Babic
2013-10-01 14:26 ` Eric Nelson [this message]
2013-10-01 14:49 ` Stefano Babic
2013-10-01 15:56 ` Eric Nelson
2013-10-01 16:10 ` Stefano Babic
2013-10-01 16:17 ` Eric Nelson
2013-10-01 19:50 ` Benoît Thébaudeau
2013-10-01 20:01 ` Otavio Salvador
2013-10-01 20:21 ` Benoît Thébaudeau
2013-10-01 20:25 ` Fabio Estevam
2013-10-01 21:29 ` Eric Nelson
2013-10-02 6:06 ` Stefano Babic
2013-10-01 16:23 ` Benoît Thébaudeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524ADB98.9010605@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox