From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 02 Oct 2013 08:06:20 +0200 Subject: [U-Boot] [PATCH] mx6: Add IOMUX_CONFIG_SION flag to all GPIO pins In-Reply-To: <1938105334.2320821.1380657041367.JavaMail.zimbra@advansee.com> References: <1380492900-910-1-git-send-email-otavio@ossystems.com.br> <524ACA60.3020504@denx.de> <524ADB98.9010605@boundarydevices.com> <524AE107.1050404@denx.de> <524AF09B.7040505@boundarydevices.com> <524AF3ED.6030501@denx.de> <524AF582.1030907@boundarydevices.com> <1938105334.2320821.1380657041367.JavaMail.zimbra@advansee.com> Message-ID: <524BB7DC.3070004@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Benoit, Eric, Otavio, On 01/10/2013 21:50, Beno?t Th?baudeau wrote: >> >> You probably wouldn't just set SION on all pins, right? I suspect >> that there'd be some ramification in terms of power consumption if >> nothing else. > > Right. Well, instead of adding SION to the pin definition header files, then we > could just add SION where needed on a per-pin basis, e.g.: > --- > imx_iomux_v3_setup_pad(MX6_PAD_NANDF_D1__GPIO_2_1 | > IOMUX_CONFIG_SION << MUX_MODE_SHIFT); > --- > > A helper macro could be defined in arch/arm/include/asm/imx-common/iomux-v3.h in > order to simplify the writing, e.g.: > --- > #define MUX_MODE_SION (IOMUX_CONFIG_SION << MUX_MODE_SHIFT) > --- > imx_iomux_v3_setup_pad(MX6_PAD_NANDF_D1__GPIO_2_1 | MUX_MODE_SION); > --- > > On the Linux side of things, the CONFIG field in the pinctrl DT bindings already > provides bit 30 for SION. Hence, using MUX_MODE_SION like above would be close > to Linux's pin config. > Agree, this is a better solution for the issue, and it is easier to be tracked as setting SION for all pins. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================