From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 02 Oct 2013 15:51:55 +0200 Subject: [U-Boot] [PATCH 1/4] exynos: i2c: Fix i2c driver to handle NACKs properly In-Reply-To: <1380524290-9644-2-git-send-email-ch.naveen@samsung.com> References: <1363085897-19814-1-git-send-email-ch.naveen@samsung.com> <1380524290-9644-1-git-send-email-ch.naveen@samsung.com> <1380524290-9644-2-git-send-email-ch.naveen@samsung.com> Message-ID: <524C24FB.1030101@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Naveen, Am 30.09.2013 08:58, schrieb Naveen Krishna Chatradhi: > The Exynos5 i2c driver does not handle NACKs properly. This change: > > - fixes the NACK processing problem (do not continue transaction if > address cycle was NACKed) > > - eliminates a fair amount of duplicate code > > Signed-off-by: Vadim Bendebury > Reviewed-by: Simon Glass > Signed-off-by: Naveen Krishna Chatradhi > --- > drivers/i2c/s3c24x0_i2c.c | 213 +++++++++++++++++++-------------------------- > 1 file changed, 89 insertions(+), 124 deletions(-) Patch introduces a compileerror for the VCMA9 board: Testing VCMA9 on -00058-ga882b9e Wed Oct 2 09:02:24 EDT 2013 Configuring for VCMA9 board... s3c24x0_i2c.c:234:3: error: 'i' undeclared (first use in this function) make[1]: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/s3c24x0_i2c.o] Error 1 make: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/libi2c.o] Error 2 /opt/linaro/gcc-linaro-arm-linux-gnueabihf-4.7-2013.03-20130313_linux/bin/arm-linux-gnueabihf-size: 'VCMA9/u-boot': No such file s3c24x0_i2c.c: In function 'i2c_init': s3c24x0_i2c.c:234:3: error: 'i' undeclared (first use in this function) s3c24x0_i2c.c:234:3: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/s3c24x0_i2c.o] Error 1 make: *** [/home/trini/work/u-boot/u-boot/VCMA9/drivers/i2c/libi2c.o] Error 2 make: *** Waiting for unfinished jobs.... Please check this and add, when posting this patch again, the board Maintainer: David M?ller to Cc, so he maybe can test it ... Thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany