public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 4/3] i.MX6DQ/DLS: remove unused pad declarations
Date: Fri, 04 Oct 2013 16:23:14 -0700	[thread overview]
Message-ID: <524F4DE2.4070606@boundarydevices.com> (raw)
In-Reply-To: <5239FC87.6050500@boundarydevices.com>

Hi all,

I'm just following up on this patch.

On 09/18/2013 12:18 PM, Eric Nelson wrote:
 > Hi Otavio,
 >
 > On 09/18/2013 11:27 AM, Otavio Salvador wrote:
 >> On Wed, Sep 18, 2013 at 3:14 PM, Eric Nelson
 >> <eric.nelson@boundarydevices.com> wrote:
 >>> That's not a typo. I really did intend this to be an add-on to the
 >>> series described here:
 >>>
 >>>          http://lists.denx.de/pipermail/u-boot/2013-September/#162774
 >>>
 >>> This patch assumes that the answer about what to do with pads that
 >>> aren't in the Linux tree is to delete them from U-Boot.
 >>>
 >>> No boards are currently referring to them, and the names are still
 >>> a jumble of mis-matched abbreviations.
 >>>
 >>> After applying this patch, there are still over 200 differences in
 >>> pad declarations between the i.MX6D/Q and the i.MX6DL/S header files,
 >>> but the differences may all be meaningful.
 >>>
 >>> Specifically:
 >>>
 >>> 142  have names referring to IPU2 on i.MX6D/Q and LCDIF on i.MX6DL/S
 >>>       It's not clear to me whether these can be used in the same
 >>>       manner
 >>>       on both variants.
 >>>   50  refer to the EPDC signals only available on i.MX6DL/S
 >>>    8  refer to ACLK_FREERUN, and it's not clear from the
 >>>       documentation
 >>>       whether this exists on i.MX6 D/Q
 >>>   15  refer to the ECSPI5 component, only available on i.MX6 D/Q
 >>>    8  refer to the I2C4 component, only available on i.MX6 DL/S
 >>>
 >>> These pad declarations seem to have made it into the Linux kernel
 >>> for i.MX6DL and should be added to i.MX6DQ:
 >>>
 >>>   38  refer to IPU1_CSI1, which is available on both variants and
 >>>       should be added to the i.MX6D/Q declarations in Linux and >>> 
       U-Boot
 >>>    4  refer to USBOH3 functions that should be added to i.MX6 D/Q
 >>>       in Linux and U-Boot
 >>>
 >>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
 >>
 >> Personally I think this is the way to go.
 >>
 >
 > I guess I didn't really weigh in, but I'm in favor of 'ding now,
 > add later if needed'.
 >

I don't think Stefano, Shawn, or Fabio ever weighed in on whether to
     - remove them all, or
     - review and remove or consolidate names, or
     - leave them alone

Tapani requested that the MMDC_DRAM pads be kept, but I don't see
a response to the comment that these are likely to be configured in
DCD data at least for some boards, so the structs won't be useful
and #defines would do the trick.

Please let me know your thoughts.

Regards,


Eric

  parent reply	other threads:[~2013-10-04 23:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1379528046-21560-1-git-send-email-eric.nelson@boundarydevices.com>
     [not found] ` <CAP9ODKpE=p+kw+USXts03zhgUFL2QAHz0=RhOQp2c9ZR80fU8w@mail.gmail.com>
     [not found]   ` <5239FC87.6050500@boundarydevices.com>
     [not found]     ` <CAP9ODKowCdG8xYPm8yDyqt+OdK5AJfH7XSD3pobo2B1RAhk5yQ@mail.gmail.com>
     [not found]       ` <523B0563.4050706@boundarydevices.com>
     [not found]         ` <20130920084416.GA13620@S2101-09.ap.freescale.net>
2013-09-20 14:42           ` [U-Boot] i.MX6SL pad declarations (was [RFC PATCH 4/3] i.MX6DQ/DLS: remove unused pad declarations) Eric Nelson
2013-10-04 23:23     ` Eric Nelson [this message]
     [not found]     ` <524F4A9F.4080102@boundarydevices.com>
     [not found]       ` <5256BCEE.6010002@denx.de>
     [not found]         ` <5256C7EB.6060105@boundarydevices.com>
     [not found]           ` <CAOMZO5Cagnz0g79fdzFHHGARS=MQ58epd08+0YAe8qz8vT2P8A@mail.gmail.com>
2013-10-10 15:35             ` [U-Boot] [RFC PATCH 4/3] i.MX6DQ/DLS: remove unused pad declarations Fabio Estevam
2013-10-11  2:10               ` Shawn Guo
2013-10-11  2:39                 ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524F4DE2.4070606@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox