[U-Boot] [PATCH v3 0/4] Board support and feature for LaCie devices

Prafulla Wadaskar
2012-09-06T18:17:50Z

> -----Original Message-----
> From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
> Sent: 06 September 2012 08:07
> To: U-Boot
> Cc: Simon Guinot; Prafulla Wadaskar
> Subject: Re: [PATCH v3 0/4] Board support and feature for LaCie
> devices
>
> Hi Simon,
>
> On Thu, 6 Sep 2012 13:27:19 +0200, Simon Guinot
> <simon.guinot@sequanux.org> wrote:
>
> > On Thu, Sep 06, 2012 at 11:25:23AM +0200, Simon Guinot wrote:
> > > Changes for v3:
> > > - Rebased against u-boot-mv/master and u-boot-arm/master.
> > >
> > > Changes for v2:
> > > - Move board support and feature into a separate patch set.
> > > - Move mach-types update into a separate patch.
> > >
> > > Simon Guinot (4):
> > > lacie_kw: add support for EFI partitions
> > > ARM: add netspace_mini_v2 to mach-types.h
> > > ARM: add support for Network Space v2 Lite and Mini
> > > ARM: add support for d2 Network v2
> > >
> > > arch/arm/include/asm/mach-types.h | 13 +++
> > > board/LaCie/common/common.c | 36 ++++++-
> > > board/LaCie/common/common.h | 1 +
> > > board/LaCie/netspace_v2/kwbimage-ns2l.cfg | 162
> > > +++++++++++++++++++++++++++++
> > > board/LaCie/netspace_v2/netspace_v2.c | 4 +
> > > boards.cfg | 3 +
> > > include/configs/lacie_kw.h | 42 ++++++-- 7 files
> > > changed, 252 insertions(+), 9 deletions(-) create mode 100644
> > > board/LaCie/netspace_v2/kwbimage-ns2l.cfg
> >
> > Hi Albert and Prafulla,
> >
> > I thinks I miss the point with this v3 patch series. I understand
> now,
> > I have to drop the patch: "ARM: add netspace_mini_v2 to mach-
> types.h"
> >
> > The problem is that the boards netspace_mini_v2, and more recently
> > netspace_lite_v2, have been removed from the Linux mach-types file.
> > As a temporary solution, I could include the missing MACH_TYPE_
> > definitions to the header configs/lacie_kw.h.
> >
> > Is that correct ?
>
> Correct. Boards which are being dropped from Linux mach-types have not
> necessarily died or stopped using (older) Linux or U-Boot, so we need
> to keep their mach-types around, in their board config headers.
>
> I will pull the mach-types file myself and either remove redundant
> mach
> types from config header files or Cc: maintainers of boards the
> machine
> type of which have been dropped so that they fix their boards.
>
> > If yes, do you want me to resend the whole patch
> > series or just an update for the patch "ARM: add support for Network
> > Space v2 Lite and Mini" ?
>
> Only updating that patch in the series is fine with me. Prafulla ?

If the MACHINE ID is not available in the mach_types.h, then we can define in the board specific file instead of updating mach_types.h?

Hi Simon, can you take care of this and post v4?

Regards...
Prafulla . . .